Skip to content

Fixed torch version in docker push_all.sh #3300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 7, 2024
Merged

Fixed torch version in docker push_all.sh #3300

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e38dd31
Updated pytorch version in CI and docker
vfdev-5 Nov 7, 2024
b9f0b17
Fix docker tag
vfdev-5 Nov 7, 2024
cd7cc11
Fix docker tag value removing +cu124 like words from torch version
vfdev-5 Nov 7, 2024
62a080f
Fix version compare in test_image
vfdev-5 Nov 7, 2024
0407757
Fixed torch version in docker push_all.sh
vfdev-5 Nov 7, 2024
d59b500
Merge branch 'master' into update-pytorch-versions-ci
vfdev-5 Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions docker/push_all.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,9 @@ echo $DOCKER_TOKEN | docker login --username=$DOCKER_USER --password-stdin

set -xeu


if [ ${push_selected_image} == "all" ]; then

image_name="base"
image_tag=`docker run --rm -i pytorchignite/${image_name}:latest python -c "import torch; import ignite; print(torch.__version__ + \"-\" + ignite.__version__, end=\"\")"`
image_tag=`docker run --rm -i pytorchignite/${image_name}:latest python -c "import torch; import ignite; print(torch.__version__.split('+')[0] + \"-\" + ignite.__version__, end=\"\")"`

for image_name in "base" "vision" "nlp" "apex" "apex-vision" "apex-nlp"
do
Expand All @@ -40,9 +38,6 @@ if [ ${push_selected_image} == "all" ]; then

done

image_name="hvd-base"
image_tag=`docker run --rm -i pytorchignite/${image_name}:latest python -c "import torch; import ignite; print(torch.__version__ + \"-\" + ignite.__version__, end=\"\")"`

for image_name in "hvd-base" "hvd-vision" "hvd-nlp" "hvd-apex" "hvd-apex-vision" "hvd-apex-nlp"
do

Expand All @@ -52,9 +47,6 @@ if [ ${push_selected_image} == "all" ]; then
done

# DEPRECATED due to no activity
# image_name="msdp-apex"
# image_tag=`docker run --rm -i pytorchignite/${image_name}:latest python -c "import torch; import ignite; print(torch.__version__ + \"-\" + ignite.__version__, end=\"\")"`

# for image_name in "msdp-apex" "msdp-apex-vision" "msdp-apex-nlp"
# do

Expand All @@ -66,7 +58,7 @@ if [ ${push_selected_image} == "all" ]; then
else

image_name=${push_selected_image}
image_tag=`docker run --rm -i pytorchignite/${image_name}:latest python -c "import torch; import ignite; print(torch.__version__ + \"-\" + ignite.__version__, end=\"\")"`
image_tag=`docker run --rm -i pytorchignite/${image_name}:latest python -c "import torch; import ignite; print(torch.__version__.split('+')[0] + \"-\" + ignite.__version__, end=\"\")"`

docker push pytorchignite/${image_name}:latest
docker push pytorchignite/${image_name}:${image_tag}
Expand Down
Loading