Skip to content

add fbresearch_logger.py #3215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 26, 2024
Merged

add fbresearch_logger.py #3215

merged 6 commits into from
Mar 26, 2024

Conversation

leej3
Copy link
Contributor

@leej3 leej3 commented Mar 22, 2024 •
edited
Loading

Description:
Add FBResearchLogger class from unmerged branch object-detection-example

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@github-actions github-actions bot added the module: handlers Core Handlers module label Mar 22, 2024
@leej3 leej3 force-pushed the add-fbresearch-logger branch from 8091169 to f7fe4a2 Compare March 25, 2024 14:32
@github-actions github-actions bot added the docs label Mar 25, 2024
@leej3 leej3 changed the title [WIP] add fbresearch_logger.py add fbresearch_logger.py Mar 25, 2024
leej3 added 2 commits March 26, 2024 13:55
@leej3
add fbresearch_logger.py
cc88528 
Add FBResearchLogger class from unmerged branch object-detection-example

Add minimal docs and tests
@leej3
add some mypy fixes
1f6f20d
@leej3 leej3 force-pushed the add-fbresearch-logger branch from f7fe4a2 to 1f6f20d Compare March 26, 2024 13:55
vfdev-5
vfdev-5 reviewed Mar 26, 2024
View reviewed changes
leej3 and others added 2 commits March 26, 2024 14:19
vfdev-5
vfdev-5 reviewed Mar 26, 2024
View reviewed changes
vfdev-5
vfdev-5 approved these changes Mar 26, 2024
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, John, looks good to me

@vfdev-5 vfdev-5 enabled auto-merge (squash) March 26, 2024 16:52
@vfdev-5 vfdev-5 merged commit 8cf740d into pytorch:master Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vfdev-5 vfdev-5 vfdev-5 approved these changes

Assignees
No one assigned
Labels
docs module: handlers Core Handlers module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leej3 @vfdev-5