-
-
Notifications
You must be signed in to change notification settings - Fork 654
Create get_clearml_task for Ignite.contrib.handlers.ClearMLLogger #2898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+81
−31
Merged
Changes from 4 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
dbe3ec2
add get_clearml_task method and test cases
sallycaoyu b557a21
fix doc
sallycaoyu 8f93dd2
fix doc
sallycaoyu f322dc2
remove local files
sallycaoyu 7b7eca3
modified get_task and added point1
sallycaoyu d579afe
remove local files
sallycaoyu fe90e71
add get_task_bypass test
sallycaoyu 7d1dd2b
modify docstring
sallycaoyu a782373
fix types
sallycaoyu 0aadcba
add pytest warning context manager
sallycaoyu c628a28
change task in bypass mode from _Stub to an offline Task
sallycaoyu f5b87dd
change link docstring fmt
sallycaoyu 47dca59
change docstring fmt
sallycaoyu be97cde
Merge branch 'master' into clearmllogger-task
vfdev-5 e972faa
Merge branch 'master' of github.com:pytorch/ignite into clearmllogger…
sallycaoyu 3819618
delete return
sallycaoyu 67ed056
Merge branch 'clearmllogger-task' of github.com:sallycaoyu/ignite int…
sallycaoyu bb5d49b
Merge branch 'master' into clearmllogger-task
vfdev-5 2c211d4
Merge branch 'master' into clearmllogger-task
vfdev-5 8ab771a
remove the mock projects of Task.current() from test_clearml_logger.py
sallycaoyu 7aa7959
change previous mocked Task.current() to create real Task objects
sallycaoyu 3d7b219
remove extra files
sallycaoyu 67f38f9
changed Task.current() to magicmock in test_clearml_logger
sallycaoyu e0329c1
Merge branch 'master' into clearmllogger-task
vfdev-5 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vfdev-5 marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should use a lazy import here instead. See line 117, https://github.com/pytorch/ignite/pull/2898/files#diff-833e2ffb3025440eee9f6edb419659ce7460b9d263c23186d7c260218c9b8e1fR117