Refactor PSNR and SSIM #2797
Merged
Refactor PSNR and SSIM #2797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadra-barikbin
force-pushed
the
Refactor-psnr
branch
from
7e46e3d to
85586d6
Compare
3 tasks
|
@sadra-barikbin can you provide PR description with the info we decided in discord. |
|
Let's also swtich SSIM back to float as well |
vfdev-5
approved these changes
Dec 9, 2022
There was a problem hiding this comment.
Thanks, LGTM!
However we need to fix horovod tests which are skipped right now:
tests/ignite/metrics/test_psnr.py::test_distrib_input_float[horovod] SKIPPED (Skip if no Horovod dist support) [ 86%]
https://github.com/pytorch/ignite/actions/runs/3654919549/jobs/6175755766#step:9:1770
|
Don't you merge it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
computemethod returnsfloatin PSNR and SSIM as it does in other metrics.