Skip to content

update set-output usage[WIP] #2786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 27, 2022
Merged

update set-output usage[WIP] #2786

merged 3 commits into from
Nov 27, 2022

Conversation

guptaaryan16
Copy link
Contributor

Fixes #2784

Description: I updated all the old set-output cases with new syntax as specified in the issue and the blog.

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@github-actions github-actions bot added the ci CI label Nov 26, 2022
@vfdev-5
Copy link
Collaborator

vfdev-5 commented Nov 26, 2022

Thanks for the PR @guptaaryan16 but I think it's not a correct way, see the error : https://github.com/pytorch/ignite/actions/runs/3553020030/jobs/5968378813#step:6:12

Please check the GitHub docs how to save / load output. Thanks

@guptaaryan16 guptaaryan16 changed the title update set-output usage update set-output usage[WIP] Nov 26, 2022
@guptaaryan16
Copy link
Contributor Author

Thanks you solved the issue I was stuck on

vfdev-5
vfdev-5 approved these changes Nov 27, 2022
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @guptaaryan16 , lgtm !

@vfdev-5 vfdev-5 merged commit e0a2879 into pytorch:master Nov 27, 2022
@guptaaryan16 guptaaryan16 deleted the patch-1 branch December 1, 2022 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vfdev-5 vfdev-5 vfdev-5 approved these changes

Assignees
No one assigned
Labels
ci CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CI] update set-output usage
2 participants
@guptaaryan16 @vfdev-5