Skip to content

Fix failing CI #2757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 29, 2022
+7 −4
Merged

Fix failing CI #2757

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
65adffd
make pip install verbose in CI
louis-she Oct 29, 2022
4823944
fix neptune error
louis-she Oct 29, 2022
5b72c98
fix gym version
louis-she Oct 29, 2022
b689650
ping gym version
louis-she Oct 29, 2022
a22e01d
ping neptune version to the last version that has the
louis-she Oct 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/gpu-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ jobs:

- name: Install dependencies
run: |
pip install -r requirements-dev.txt -qq
pip install -r requirements-dev.txt
python setup.py install

- name: Run 1 Node 2 GPUs Unit Tests
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/unit-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ jobs:

- name: Install dependencies
run: |
pip install -r requirements-dev.txt -qq
pip install -r requirements-dev.txt
python setup.py install

- name: Check code formatting
Expand Down
5 changes: 4 additions & 1 deletion ignite/contrib/handlers/neptune_logger.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,10 @@ def __init__(self, *args: Any, **kwargs: Any) -> None:

if kwargs.get("offline_mode", False):
self.mode = "offline"
neptune.init(project_qualified_name="dry-run/project", backend=neptune.OfflineBackend())
neptune.init(
Copy link
Collaborator

@vfdev-5 vfdev-5 Oct 29, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Blaizzy can you check if this is a correct fix ?
Apparently, we have to change more code, see #2758

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will take a look at it tomorrow morning :)

project_qualified_name="dry-run/project",
backend=neptune.OfflineBackend(),
)
else:
self.mode = "online"
neptune.init(api_token=kwargs.get("api_token"), project_qualified_name=kwargs.get("project_name"))
Expand Down
2 changes: 1 addition & 1 deletion requirements-dev.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ polyaxon
polyaxon-client
wandb
mlflow
neptune-client
neptune-client==0.16.9
tensorboard
torchvision
pynvml
Expand Down