Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2745
It's a bug of visdom
0.2.2
fossasia/visdom#878 , they already released0.2.2.post1
to fix it. Actually rerunning the tests without pip cache will automatically solve the import error since we are not pinning the version inrequirements-dev.txt
, so it will get the fixed version.But after updating to
0.2.2.post1
tests still fail due to another error, see the code changed.visdom
is frequently doing some code refactoring, I'm afraid some errors may occur for the same reason in the future. Should we pin the version or just let the CI fail and fix it?@vfdev-5