Skip to content

Conversation

louis-she
Copy link
Contributor

@louis-she louis-she commented Oct 21, 2022

Fixes #2745

It's a bug of visdom 0.2.2 fossasia/visdom#878 , they already released 0.2.2.post1 to fix it. Actually rerunning the tests without pip cache will automatically solve the import error since we are not pinning the version in requirements-dev.txt, so it will get the fixed version.

But after updating to 0.2.2.post1 tests still fail due to another error, see the code changed.

visdom is frequently doing some code refactoring, I'm afraid some errors may occur for the same reason in the future. Should we pin the version or just let the CI fail and fix it?

@vfdev-5

@louis-she louis-she changed the title fix visdom bug Fix visdom bug Oct 22, 2022
@louis-she
Copy link
Contributor Author

louis-she commented Oct 22, 2022

I've pinned the version of visdom in requirements-dev.txt or some tests will fail due to getting the previous version.

@vfdev-5
Copy link
Collaborator

vfdev-5 commented Oct 22, 2022

@louis-she thanks a lot for the fixes !
I agree with you that we can fix a version and once they stabilized the code (one day) we can remove the pinning condition.

@louis-she
Copy link
Contributor Author

The failed test seems not to be relative to the changes. Can we retrigger the failed workflow again? I can not find the rerun button. @vfdev-5

Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the PR, @louis-she !

@vfdev-5 vfdev-5 merged commit 7f01401 into pytorch:master Oct 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scheduled workflow failed
2 participants