Skip to content

Conversation

puhuk
Copy link
Contributor

@puhuk puhuk commented Aug 22, 2022

Description: Update mean_absolute_relative_error, mean_error, mean_normalized_bias to generate with different rank

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

Description: Update `mean_absolute_relative_error`, `mean_error`, `mean_normalized_bias`  to generate with different rank
@puhuk puhuk changed the title Update 3 metrics in test for generating data with different rank Update mean_absolute_relative_error, mean_error, mean_normalized_bias in test for generating data with different rank Aug 23, 2022
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @puhuk !

@vfdev-5 vfdev-5 enabled auto-merge (squash) August 23, 2022 07:14
@vfdev-5 vfdev-5 merged commit 0090f62 into pytorch:master Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants