Skip to content

Conversation

kamalojasv181
Copy link
Contributor

@kamalojasv181 kamalojasv181 commented Jul 19, 2022

Related #2522

Description: Parametrized tests for tests/ignite/metrics/test_accumulation using pytest.

@vfdev-5
Copy link
Collaborator

vfdev-5 commented Jul 19, 2022

@kamalojasv181, please change Fixes -> Related

Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @kamalojasv181
Please address my comments to improve it further

Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @kamalojasv181

Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @kamalojasv181 !

@vfdev-5 vfdev-5 merged commit e45846f into pytorch:master Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants