Skip to content

Update docs with torchrun instead of torch.distributed.launch #2415 #2420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jan 17, 2022
Merged

Update docs with torchrun instead of torch.distributed.launch #2415 #2420

merged 14 commits into from
Jan 17, 2022

Conversation

Abo7atm
Copy link
Contributor

@Abo7atm Abo7atm commented Jan 14, 2022

Fixes #2415

Description:
Updated doc strings in files under distributed module that mentions torch.distributed.launch to mention torchrun too.

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@github-actions github-actions bot added the module: distributed Distributed module label Jan 14, 2022
vfdev-5
vfdev-5 reviewed Jan 14, 2022
View reviewed changes
vfdev-5
vfdev-5 reviewed Jan 14, 2022
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the PR @Abo7atm !
I left the comments with some updates to do. Basically, let's just provide torchrun examples and remove all deprecated stuff.

@vfdev-5
Copy link
Collaborator

vfdev-5 commented Jan 17, 2022 •
edited
Loading

@Abo7atm could you please update this PR today such that we could include it to the upcoming release. Thanks

Meanwhile I committed few changes I was also thinking about to one of the files.

vfdev-5
vfdev-5 reviewed Jan 17, 2022
View reviewed changes
@vfdev-5
Copy link
Collaborator

vfdev-5 commented Jan 17, 2022

@Abo7atm I'll fix everything myself and merge it such that we do not delay our release. Thanks for the PR again

vfdev-5
vfdev-5 approved these changes Jan 17, 2022
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vfdev-5 vfdev-5 enabled auto-merge (squash) January 17, 2022 12:46
@vfdev-5 vfdev-5 merged commit 7ed1c7e into pytorch:master Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vfdev-5 vfdev-5 vfdev-5 approved these changes

Assignees
No one assigned
Labels
module: distributed Distributed module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update docs with torchrun instead of torch.distributed.launch
2 participants
@Abo7atm @vfdev-5