Skip to content

Added data as None option to Engine.run #2369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 19, 2021
Merged

Added data as None option to Engine.run #2369

merged 3 commits into from
Dec 19, 2021

Conversation

vfdev-5
Copy link
Collaborator

@vfdev-5 vfdev-5 commented Dec 18, 2021

Fixes #2354

Description:

  • Added data as None option to Engine.run

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@github-actions github-actions bot added the module: engine Engine module label Dec 18, 2021
@vfdev-5 vfdev-5 requested review from trsvchn and sdesrozis December 18, 2021 22:56
sdesrozis
sdesrozis approved these changes Dec 19, 2021
View reviewed changes
Copy link
Contributor

@sdesrozis sdesrozis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vfdev-5 Thank you, LGTM !

trsvchn
trsvchn approved these changes Dec 19, 2021
View reviewed changes
Copy link
Collaborator

@trsvchn trsvchn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @vfdev-5 !

@vfdev-5 vfdev-5 enabled auto-merge (squash) December 19, 2021 17:41
@vfdev-5 vfdev-5 merged commit 94bf2da into pytorch:master Dec 19, 2021
@vfdev-5 vfdev-5 deleted the fix-2354-engine-optional-data branch December 21, 2021 11:37
Ishan-Kumar2 pushed a commit to Ishan-Kumar2/ignite that referenced this pull request Dec 26, 2021
@vfdev-5 @sdesrozis @Ishan-Kumar2
Added data as None option to Engine.run (pytorch#2369)
ade772f 
Co-authored-by: Sylvain Desroziers <sylvain.desroziers@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@sdesrozis sdesrozis sdesrozis approved these changes

@trsvchn trsvchn trsvchn approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
module: engine Engine module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Engine.run make input data optional
3 participants
@vfdev-5 @sdesrozis @trsvchn