Skip to content

[skip ci] Doctests for MeanAbsoluteError and MeanSquaredError #2280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 20, 2021
Merged

[skip ci] Doctests for MeanAbsoluteError and MeanSquaredError #2280

merged 5 commits into from
Oct 20, 2021

Conversation

DevPranjal
Copy link
Contributor

@DevPranjal DevPranjal commented Oct 19, 2021 •
edited
Loading

Addresses #2265

Description: Added doctests for MeanAbsoluteError and MeanSquaredError

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@github-actions github-actions bot added the module: metrics Metrics module label Oct 19, 2021
@sdesrozis
Copy link
Contributor

sdesrozis commented Oct 20, 2021 •
edited
Loading

@DevPranjal Thank you ! It looks good to me.

Please add [skip ci] to avoid the ci tests as only the doctests should be triggered.

@DevPranjal DevPranjal changed the title Doctests for MeanAbsoluteError and MeanSquaredError [skip ci] Doctests for MeanAbsoluteError and MeanSquaredError Oct 20, 2021
@DevPranjal
Copy link
Contributor Author

The coverage issues don't seem related to this PR. Are they?

@ydcjeff
Copy link
Contributor

ydcjeff commented Oct 20, 2021

The coverage issues don't seem related to this PR. Are they?

Yes, they are not related.

@Ishan-Kumar2
Copy link
Contributor

Partially fixes #2265

@DevPranjal in the PR description having "fixes" next to issue number will cause the issue to close on merging this PR. Maybe change it for something like "Addresses"?

@vfdev-5 vfdev-5 requested a review from sdesrozis October 20, 2021 11:00
ydcjeff
ydcjeff approved these changes Oct 20, 2021
View reviewed changes
Copy link
Contributor

@ydcjeff ydcjeff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@vfdev-5 vfdev-5 enabled auto-merge (squash) October 20, 2021 11:51
@ydcjeff ydcjeff mentioned this pull request Oct 20, 2021
Closed
51 tasks
@vfdev-5 vfdev-5 merged commit e6a1fdf into pytorch:master Oct 20, 2021
@DevPranjal DevPranjal deleted the metrics-doctest branch October 21, 2021 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdesrozis sdesrozis Awaiting requested review from sdesrozis

1 more reviewer

@ydcjeff ydcjeff ydcjeff approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
module: metrics Metrics module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DevPranjal @sdesrozis @ydcjeff @Ishan-Kumar2 @vfdev-5