Skip to content

Fix test_create_supervised on old PyTorch without amp #2250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 6, 2021
Merged

Fix test_create_supervised on old PyTorch without amp #2250

merged 2 commits into from
Oct 6, 2021

Conversation

sdesrozis
Copy link
Contributor

@sdesrozis sdesrozis commented Oct 6, 2021 •
edited by vfdev-5
Loading

Fixes #2248

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@vfdev-5
Copy link
Collaborator

vfdev-5 commented Oct 6, 2021

cc @Ishan-Kumar2

@Ishan-Kumar2
Copy link
Contributor

@sdesrozis I think > 1.5.0 will also work as 1.5.1 was passing.

@vfdev-5 vfdev-5 added the ci CI label Oct 6, 2021
@sdesrozis
Copy link
Contributor Author

@sdesrozis I think > 1.5.0 will also work as 1.5.1 was passing.

Yes https://pytorch.org/docs/1.5.0/notes/amp_examples.html

vfdev-5
vfdev-5 approved these changes Oct 6, 2021
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sdesrozis

@vfdev-5 vfdev-5 merged commit 74d5bc0 into pytorch:master Oct 6, 2021
@vfdev-5 vfdev-5 mentioned this pull request Oct 7, 2021
Closed
@sdesrozis sdesrozis deleted the fix_create_supervised_trainer_amp_old_pytorch branch February 20, 2022 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vfdev-5 vfdev-5 vfdev-5 approved these changes

Assignees
No one assigned
Labels
ci CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scheduled workflow failed
3 participants
@sdesrozis @vfdev-5 @Ishan-Kumar2