Skip to content

simplify _expand_hostlist a little #2234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 30, 2021
Merged

simplify _expand_hostlist a little #2234

merged 3 commits into from
Sep 30, 2021

Conversation

toxa23
Copy link
Contributor

@toxa23 toxa23 commented Sep 29, 2021

Description:
An attempt to simplify _NativeDistModel._expand_hostlist

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@github-actions github-actions bot added the module: distributed Distributed module label Sep 29, 2021
@vfdev-5 vfdev-5 requested a review from sdesrozis September 29, 2021 19:15
vfdev-5
vfdev-5 reviewed Sep 29, 2021
View reviewed changes
sdesrozis
sdesrozis approved these changes Sep 30, 2021
View reviewed changes
Copy link
Contributor

@sdesrozis sdesrozis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@toxa23 Thanks for this simplification. LGTM.

@sdesrozis sdesrozis merged commit eefd033 into pytorch:master Sep 30, 2021
@toxa23 toxa23 deleted the simplify-expand-hostlist branch September 30, 2021 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vfdev-5 vfdev-5 vfdev-5 left review comments

+1 more reviewer

@sdesrozis sdesrozis sdesrozis approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
module: distributed Distributed module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@toxa23 @vfdev-5 @sdesrozis