Skip to content

Conversation

toxa23
Copy link
Contributor

@toxa23 toxa23 commented Sep 25, 2021

Related to #2114

Description:
part 4 of 7, reformat docstrings in the 'engine' folder, make sure all examples have "Examples:" header, move "Args:" block to the top of method documentation

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@github-actions github-actions bot added module: engine Engine module module: utils Utils module labels Sep 25, 2021
@toxa23 toxa23 changed the title fix #2114: reformat docstrings in the 'engine' folder Related to #2114: reformat docstrings in the 'engine' folder Sep 27, 2021
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @toxa23

@vfdev-5 vfdev-5 enabled auto-merge (squash) September 28, 2021 10:00
@vfdev-5 vfdev-5 disabled auto-merge September 28, 2021 10:30
@vfdev-5 vfdev-5 merged commit eb04a29 into pytorch:master Sep 28, 2021
@toxa23 toxa23 deleted the fix-2114-reformat-engine branch September 28, 2021 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: engine Engine module module: utils Utils module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants