Skip to content

Update versionadded/versionchanged in master according to the latest releases #2164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 15, 2021
Merged

Update versionadded/versionchanged in master according to the latest releases #2164

merged 4 commits into from
Aug 15, 2021

Conversation

Chandan-h-509
Copy link
Contributor

@Chandan-h-509 Chandan-h-509 commented Aug 14, 2021 •
edited by trsvchn
Loading

Fixes #2133

Description:
Updated versionadded/versionchanged in the master according to v0.4.6 release.
Add .. versionadded:: 0.4.6 to FastaiLRFinder.

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@github-actions github-actions bot added module: contrib Contrib module module: distributed Distributed module module: engine Engine module module: handlers Core Handlers module module: metrics Metrics module module: utils Utils module labels Aug 14, 2021
vfdev-5
vfdev-5 reviewed Aug 14, 2021
View reviewed changes
trsvchn
trsvchn suggested changes Aug 14, 2021
View reviewed changes
Copy link
Collaborator

@trsvchn trsvchn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, @Chandan-h-509 !

I think we are still missing one file here

ignite/ignite/contrib/metrics/regression/fractional_bias.py

Line 37 in 84e51c3

.. versionchanged:: 0.4.5

@Chandan-h-509
Copy link
Contributor Author

Thank you @vfdev-5 .
I have updated the necessary change.
Please review.

trsvchn
trsvchn approved these changes Aug 15, 2021
View reviewed changes
Copy link
Collaborator

@trsvchn trsvchn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Chandan-h-509! LGTM!

@trsvchn trsvchn merged commit 38f30c4 into pytorch:master Aug 15, 2021
@Chandan-h-509
Copy link
Contributor Author

Thanks @trsvchn for the opportunity...Pleasure contributing.

@trsvchn
Copy link
Collaborator

trsvchn commented Aug 15, 2021 •
edited
Loading

@Chandan-h-509 Thank you for your contribution! Looking forward to seeing more PRs from you! ;) Have a great day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vfdev-5 vfdev-5 vfdev-5 left review comments

+1 more reviewer

@trsvchn trsvchn trsvchn approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
module: contrib Contrib module module: distributed Distributed module module: engine Engine module module: handlers Core Handlers module module: metrics Metrics module module: utils Utils module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update versionadded/versionchanged in master accordning to the latest releases
3 participants
@Chandan-h-509 @trsvchn @vfdev-5