CI is failing with Visdom tests on macosx

[vfdev-5]

🐛 Bug description

 tests/ignite/contrib/handlers/test_visdom_logger.py::test_logger_init_hostname_port ERROR [ 21%]
tests/ignite/contrib/handlers/test_visdom_logger.py::test_logger_init_env_vars FAILED [ 21%]
tests/ignite/contrib/handlers/test_visdom_logger.py::test_integration_no_executor FAILED [ 21%]
tests/ignite/contrib/handlers/test_visdom_logger.py::test_integration_with_executor FAILED [ 21%]

Let's temporarily disable these tests on macosx and fix them later.

• https://github.com/pytorch/ignite/pull/2201/checks?check_run_id=3730936423#step:15:201

Environment

• PyTorch Version (e.g., 1.4):
• Ignite Version (e.g., 0.3.0):
• OS (e.g., Linux):
• How you installed Ignite (conda, pip, source):
• Python version:
• Any other relevant information:

[ydcjeff]

It's failing on macos, not windows.

[avats-dev]

Hey @vfdev-5 , I want to take up this issue and contribute. Can you guide me further on how to implement this?

[vfdev-5]

@avats-dev sounds good about helping us with this issue. It is not about implementing things but using pytest skip feature to skip above mentioned tests in order to make CI happy on macosx.

[avats-dev]

Ok, I'm working on resolving this. Would let you know if need help somewhere. Thanks!

[vfdev-5]

@avats-dev any updates on this issue ?

[theory-in-progress]

Hey @vfdev-5! I think I can resolve this issue... Those tests are already being skipped on Windows, I just need to add a statement to make the tests skip on Macos too right?

[vfdev-5]

@theory-in-progress if no answer from @avats-dev in 5h, we can accept your PR on this issue as well

[vfdev-5]

@theory-in-progress could you please quickly send a PR with a fix as this issue becomes rather annoying as CI is failing. Thanks

[theory-in-progress]

Sure! I'll get right on to it.
Could you confirm if this code actually works? @vfdev-5
@pytest.mark.skipif(sys.platform.startswith("win") or sys.platform.startswith("darwin"), reason="Skip on Windows and Macosx")
this is my first time working with pytest, I'm not sure if this will actually work.

[vfdev-5]

@theory-in-progress you can either check that by setting up the same GH actions on your fork or sending a PR to this repository and we'll see