Fix [[nodiscard]] cudaDeviceEnablePeerAccess warning in gloo#498
Merged
meta-codesync[bot] merged 1 commit intopytorch:mainfrom Mar 11, 2026
Merged
Fix [[nodiscard]] cudaDeviceEnablePeerAccess warning in gloo#498meta-codesync[bot] merged 1 commit intopytorch:mainfrom
meta-codesync[bot] merged 1 commit intopytorch:mainfrom
Conversation
Summary: ROCm 7.0+ HIP headers annotate cudaDeviceEnablePeerAccess with [[nodiscard]]. Add (void) cast to suppress the warning. The cast is a no-op on CUDA and older ROCm. ghstack-source-id: 0 Reviewed By: bbeckca Differential Revision: D96004741
|
@gyllstromk has exported this pull request. If you are a Meta employee, you can view the originating Diff in D96004741. |
kapilsh
approved these changes
Mar 11, 2026
|
I had a PR to this earlier using different approach. Linking it here so we can compare and pick the best solution - https://github.com/pytorch/gloo/pull/493 |
@anvishwa-amd do you mind rebasing your PR on latest main? This PR already landed but we can take a look and try to merge. |
I've rebased my PR, Please have a look, Thank you ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
ROCm 7.0+ HIP headers annotate cudaDeviceEnablePeerAccess with
[[nodiscard]]. Add (void) cast to suppress the warning. The cast is a
no-op on CUDA and older ROCm.
ghstack-source-id: 0
Reviewed By: bbeckca
Differential Revision: D96004741