Skip to content

Fix handling of cudaDeviceEnablePeerAccess return value #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anvishwa-amd wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix handling of cudaDeviceEnablePeerAccess return value #493

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions gloo/cuda_collectives_native.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,10 +83,8 @@ class CudaLocalNativeReduce : public LocalOp<T> {

// Enable peer access for devA to memory on devB
CUDA_CHECK(cudaSetDevice(devA));
(void)cudaDeviceEnablePeerAccess(devB, 0);

// Use cudaGetLastError so that any error is cleared.
auto err = cudaGetLastError();
cudaError_t err = cudaDeviceEnablePeerAccess(devB, 0);
// peer access already enabled
if (err != cudaErrorPeerAccessAlreadyEnabled) {
CUDA_CHECK(err);
}
Expand Down Expand Up @@ -196,10 +194,8 @@ class CudaLocalNativeBroadcast : public LocalOp<T> {

// Enable peer access for devA to memory on devB
CUDA_CHECK(cudaSetDevice(devA));
(void)cudaDeviceEnablePeerAccess(devB, 0);

// Use cudaGetLastError so that any error is cleared.
auto err = cudaGetLastError();
cudaError_t err = cudaDeviceEnablePeerAccess(devB, 0);
// peer access already enabled
if (err != cudaErrorPeerAccessAlreadyEnabled) {
CUDA_CHECK(err);
}
Expand Down
Loading