Skip to content

Allow emitting mutable buffer names in schema #9935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2025

Conversation

JacobSzwejbka
Copy link
Contributor

@JacobSzwejbka JacobSzwejbka commented Apr 7, 2025

Summary: part 1 of letting people query tensors by names in runtime.

Differential Revision: D72579501

cc @angelayi

Copy link

pytorch-bot bot commented Apr 7, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9935

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 773a347 with merge base 2cce2db (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 7, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D72579501

Copy link
Contributor

@lucylq lucylq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! What is this intended to be used for, btw?

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Apr 7, 2025
Summary:

part 1 of letting people query tensors by names in runtime.

Reviewed By: lucylq

Differential Revision: D72579501
JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Apr 7, 2025
Summary:

part 1 of letting people query tensors by names in runtime.

Reviewed By: lucylq

Differential Revision: D72579501
@JacobSzwejbka JacobSzwejbka force-pushed the export-D72579501 branch 2 times, most recently from 768c329 to 268c0bf Compare April 7, 2025 20:29
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D72579501

@JacobSzwejbka JacobSzwejbka added module: exir Issues related to Export IR and the code under exir/ release notes: api Changes to public facing apis (any interfaces, pybinded runtime methods, etc.) labels Apr 7, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D72579501

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Apr 7, 2025
Summary:
Pull Request resolved: pytorch#9935

part 1 of letting people query tensors by names in runtime.

Reviewed By: lucylq

Differential Revision: D72579501
JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Apr 7, 2025
Summary:

part 1 of letting people query tensors by names in runtime.

Reviewed By: tarun292, lucylq

Differential Revision: D72579501
JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Apr 7, 2025
Summary:

part 1 of letting people query tensors by names in runtime.

Reviewed By: tarun292, lucylq

Differential Revision: D72579501
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D72579501

Summary:
Pull Request resolved: pytorch#9935

part 1 of letting people query tensors by names in runtime.

Reviewed By: tarun292, lucylq

Differential Revision: D72579501
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D72579501

@facebook-github-bot facebook-github-bot merged commit 1facfa9 into pytorch:main Apr 8, 2025
82 of 84 checks passed
kirklandsign pushed a commit that referenced this pull request Apr 11, 2025
Differential Revision: D72579501

Pull Request resolved: #9935
keyprocedure pushed a commit to keyprocedure/executorch that referenced this pull request Apr 21, 2025
Differential Revision: D72579501

Pull Request resolved: pytorch#9935
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported module: exir Issues related to Export IR and the code under exir/ release notes: api Changes to public facing apis (any interfaces, pybinded runtime methods, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants