Skip to content

Arm backend: Convert assert to raise ValueError in op_clamp #9932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 11, 2025
Merged

Arm backend: Convert assert to raise ValueError in op_clamp #9932

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
114573e
Arm backend: Convert assert to raise ValueError in op_clamp
Sebastian-Larsson Apr 7, 2025
eb63786
Merge branch 'pytorch:main' into assert_clamp
Sebastian-Larsson Apr 8, 2025
b2d7110
Merge branch 'main' into assert_clamp
zingo Apr 11, 2025
e8ff4ba
Merge branch 'main' into assert_clamp
zingo Apr 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions backends/arm/operators/op_clamp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,8 @@ def cast_type(value: Any) -> int | float:
# Attempt to cast to float
return float(value)

assert 2 <= len(node.args) <= 3
if len(node.args) != 2 and len(node.args) != 3:
raise ValueError(f"Expected len(node.args) to be 2 or 3, got {node.args}")

min_arg = dtype_min
max_arg = dtype_max
Expand All @@ -84,7 +85,10 @@ def define_node(
inputs: List[TosaArg],
output: TosaArg,
) -> None:
assert len(node.all_input_nodes) == 1
if len(node.all_input_nodes) != 1:
raise ValueError(
f"Expected 1 input for {self.target}, got {len(node.all_input_nodes)}"
)

min_int8, max_int8 = self._get_min_max_arguments(
node,
Expand Down Expand Up @@ -122,7 +126,10 @@ def define_node(
inputs: List[TosaArg],
output: TosaArg,
) -> None:
assert len(node.all_input_nodes) == 1
if len(node.all_input_nodes) != 1:
raise ValueError(
f"Expected 1 input for {self.target}, got {len(node.all_input_nodes)}"
)

if inputs[0].dtype == ts.DType.INT8:
# Call the inherited define_node for handling integers
Expand Down
Loading