Skip to content

[Executorch][sdpa] Add accidentaly removed flash attentiona args check #9887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2025
Merged

[Executorch][sdpa] Add accidentaly removed flash attentiona args check #9887

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions extension/llm/custom_ops/op_sdpa.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,6 +294,13 @@ Tensor& custom_sdpa_out(
output,
"attn_mask and is_causal cannot be set at the same time");

ET_KERNEL_CHECK_MSG(
ctx,
validate_flash_attention_args(q, k, v, attn_mask),
InvalidArgument,
output,
"Invalid arguments");

ET_CHECK_MSG(q.dim() == 4, "query must be a 4D tensor");

const int64_t seq_len = q.size(1);
Expand Down
Loading