Arm backend: Improve pre-push hook #9873
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now checks: * License header * Lintrunner * Commit message This is done for all commits that are not on the remote branch the current branch is tracking. Commit message checks are: * Subject limit is 72 characters * Subject should start with "Arm backend: " + an imperative verb * Body limit is 72 characters * Must contain Signed-off-by Lines can be shorter than 72, but unless it's a new paragraph each line should get to as close to 72 characters as possible. This is not checked by the hook. Signed-off-by: Sebastian Larsson <sebastian.larsson@arm.com> Change-Id: Ie99d1ba4603455ededc8a12b440058c8665ff66c Signed-off-by: Yufeng Shi <yufeng.shi@arm.com>
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9873
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 62f26cc with merge base 3600d4f ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Sebastian-Larsson
added
partner: arm
|
CI failure seems unrelated. Started happening after this was merged: #9643 |
zingo
approved these changes
Apr 3, 2025
kirklandsign
pushed a commit
that referenced
this pull request
Apr 11, 2025
Now checks: * License header * Lintrunner * Commit message This is done for all commits that are not on the remote branch the current branch is tracking. Commit message checks are: * Subject limit is 72 characters * Subject should start with "Arm backend: " + an imperative verb * Body limit is 72 characters * Must contain Signed-off-by Lines can be shorter than 72, but unless it's a new paragraph each line should get to as close to 72 characters as possible. This is not checked by the hook. Signed-off-by: Sebastian Larsson <sebastian.larsson@arm.com> Signed-off-by: Yufeng Shi <yufeng.shi@arm.com>
This was referenced Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now checks:
This is done for all commits that are not on the remote branch the current branch is tracking.
Commit message checks are:
Lines can be shorter than 72, but unless it's a new paragraph each line should get to as close to 72 characters as possible. This is not checked by the hook.
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218