Arm backend: Add where.self #9869
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add operator where.self, which maps to the SELECT operator in the TOSA specification. Tests are also added for the aformentioned operator. Change-Id: I7bd609dd741357b78a0a059cb0f61f2c975bbf06 Signed-off-by: Sebastian Larsson <sebastian.larsson@arm.com>
The function `get_quant_properties` can return `None`, which was not reflected in its return type annotation. This could cause type checker warnings or incorrect assumptions about its return value. Update the return type from `_OpQuantProperties` to `_OpQuantProperties | None` to correctly represent the possible outputs. Change-Id: I1f360ab1b9dcda119473f17a3eb46ffbaeba831c Signed-off-by: Sebastian Larsson <sebastian.larsson@arm.com>
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9869
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 7c92392 with merge base 3600d4f ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Sebastian-Larsson
added
partner: arm
|
CI failure seems unrelated. Started happening after this was merged: #9643 |
zingo
approved these changes
Apr 3, 2025
kirklandsign
pushed a commit
that referenced
this pull request
Apr 11, 2025
Add operator where.self, which maps to the SELECT operator in the TOSA specification. Tests are also added for the aforementioned operator. Signed-off-by: Sebastian Larsson <sebastian.larsson@arm.com>
This was referenced Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add operator where.self, which maps to the SELECT operator in the TOSA
specification. Tests are also added for the aforementioned operator.
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218