Skip to content

Arm Backend: Fixes related to pytorch updates #9834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2025

Conversation

SaoirseARM
Copy link
Collaborator

@SaoirseARM SaoirseARM commented Apr 2, 2025

Summary

  • Update to error message for unsupported types
  • Check file extension in test_debug_feats
  • Adding expected failures for some unsupported operators in tests

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

- Update to error message for unsupported types
- Check file extension in test_debug_feats
- Adding failures for some unsupported operators in tests
@SaoirseARM SaoirseARM requested a review from zingo April 2, 2025 09:35
@SaoirseARM SaoirseARM requested a review from digantdesai as a code owner April 2, 2025 09:35
Copy link

pytorch-bot bot commented Apr 2, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9834

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 2 Pending

As of commit 9e9b0ec with merge base 4987f0b (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 2, 2025
@SaoirseARM
Copy link
Collaborator Author

@pytorchbot label ciflow/trunk

@SaoirseARM
Copy link
Collaborator Author

@pytorchbot label 'partner: arm'

@pytorch-bot pytorch-bot bot added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label Apr 2, 2025
@SaoirseARM
Copy link
Collaborator Author

@pytorchbot label "topic: not user facing"

@zingo zingo merged commit 376d66a into pytorch:main Apr 2, 2025
166 of 169 checks passed
@@ -104,7 +104,15 @@ def test_nn_functional_MI(test_data):
raise e


@parametrize("test_data", module_tests)
x_fails = {
"normalize": "MLETORCH-852: Support aten.index_put.default",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MLETORCH-* - are these issues tracking ET work? if yes, would it be possible to put them under ET GH? Just for visibility. If I can access these from outside Arm that would be OK too.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

Thanks for the review.
We had some discussions yesterday on the best way to do this and we will start looking into this as soon as possible.

Thanks,
Saoirse

@SaoirseARM SaoirseARM deleted the toupstream/pytorch_fix branch April 4, 2025 09:42
kirklandsign pushed a commit that referenced this pull request Apr 11, 2025
### Summary
- Update to error message for unsupported types
- Check file extension in test_debug_feats
- Adding expected failures for some unsupported operators in tests




cc @digantdesai @freddan80 @per @zingo @oscarandersson8218
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants