introduce DelegateDebugIntId #9832
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: EventTracer misused `DebugHandle` type (uint32_t) for debug id of both op-level and delegation level. In fact for delegate_debug_id we should use int32_t instead. This diff creates a new type called `DelegateDebugIntId` specific for delegate_debug_id, and a new flag kUnsetDelegateDebugIntId for unset delegate debug id. Updates corresponding tests as well. Differential Revision: D72297495
Gasoonjia
requested review from
JacobSzwejbka,
lucylq,
swolchok and
tarun292
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9832
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 3c3f17f with merge base 4987f0b ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D72297495 |
Gasoonjia
added a commit
to Gasoonjia/executorch-1
that referenced
this pull request
Apr 2, 2025
Summary: EventTracer misused `DebugHandle` type (uint32_t) for debug id of both op-level and delegation level. In fact for delegate_debug_id we should use int32_t instead. This diff creates a new type called `DelegateDebugIntId` specific for delegate_debug_id, and a new flag kUnsetDelegateDebugIntId for unset delegate debug id. Updates corresponding tests as well. Differential Revision: D72297495
tarun292
approved these changes
Apr 2, 2025
tarun292
approved these changes
Apr 2, 2025
kirklandsign
pushed a commit
that referenced
this pull request
Apr 11, 2025
Differential Revision: D72297495 Pull Request resolved: #9832
This was referenced Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
EventTracer misused
DebugHandletype (uint32_t) for debug id of both op-level and delegation level. In fact for delegate_debug_id we should use int32_t instead.This diff creates a new type called
DelegateDebugIntIdspecific for delegate_debug_id, and a new flag kUnsetDelegateDebugIntId for unset delegate debug id.Updates corresponding tests as well.
Differential Revision: D72297495