Expose symbols on macos in the xplat pytorch stack #9819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9819
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 2df119c with merge base 2b4e525 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D72255474 |
stepanhruda
added a commit
to stepanhruda/pytorch
that referenced
this pull request
Apr 1, 2025
Summary: X-link: pytorch/executorch#9819 Had to revert D71321310 because it affected way too many targets and build sizes. These changes should expose just enough symbols to be buildable in arvr mode on macOS. Could potentially make narrow it down even more by avoiding eg `get_pt_compiler_flags` Differential Revision: D72255474
|
@pytorchbot label "topic: not user facing" |
stepanhruda
force-pushed
the
export-D72255474
branch
from
9bf01ab to
c281557
Compare
stepanhruda
added a commit
to stepanhruda/executorch
that referenced
this pull request
Apr 3, 2025
Summary: X-link: pytorch/pytorch#150487 Had to revert D71321310 because it affected way too many targets and build sizes. These changes should expose just enough symbols to be buildable in arvr mode on macOS. Could potentially make narrow it down even more by avoiding eg `get_pt_compiler_flags` Differential Revision: D72255474
stepanhruda
added a commit
to stepanhruda/pytorch
that referenced
this pull request
Apr 3, 2025
Summary: X-link: pytorch/executorch#9819 Had to revert D71321310 because it affected way too many targets and build sizes. These changes should expose just enough symbols to be buildable in arvr mode on macOS. Could potentially make narrow it down even more by avoiding eg `get_pt_compiler_flags` Differential Revision: D72255474
|
This pull request was exported from Phabricator. Differential Revision: D72255474 |
stepanhruda
added a commit
to stepanhruda/executorch
that referenced
this pull request
Apr 3, 2025
Summary: X-link: pytorch/pytorch#150487 Pull Request resolved: pytorch#9819 Had to revert D71321310 because it affected way too many targets and build sizes. These changes should expose just enough symbols to be buildable in arvr mode on macOS. Could potentially make narrow it down even more by avoiding eg `get_pt_compiler_flags` Differential Revision: D72255474
stepanhruda
force-pushed
the
export-D72255474
branch
from
c281557 to
0b1b312
Compare
stepanhruda
added a commit
to stepanhruda/pytorch
that referenced
this pull request
Apr 3, 2025
Summary: Pull Request resolved: pytorch#150487 X-link: pytorch/executorch#9819 Had to revert D71321310 because it affected way too many targets and build sizes. These changes should expose just enough symbols to be buildable in arvr mode on macOS. Could potentially make narrow it down even more by avoiding eg `get_pt_compiler_flags` Differential Revision: D72255474
stepanhruda
force-pushed
the
export-D72255474
branch
from
0b1b312 to
1714ca0
Compare
stepanhruda
added a commit
to stepanhruda/executorch
that referenced
this pull request
Apr 3, 2025
Summary: X-link: pytorch/pytorch#150487 Had to revert D71321310 because it affected way too many targets and build sizes. These changes should expose just enough symbols to be buildable in arvr mode on macOS. Could potentially make narrow it down even more by avoiding eg `get_pt_compiler_flags` Differential Revision: D72255474
|
This pull request was exported from Phabricator. Differential Revision: D72255474 |
stepanhruda
added a commit
to stepanhruda/pytorch
that referenced
this pull request
Apr 3, 2025
Summary: X-link: pytorch/executorch#9819 Had to revert D71321310 because it affected way too many targets and build sizes. These changes should expose just enough symbols to be buildable in arvr mode on macOS. Could potentially make narrow it down even more by avoiding eg `get_pt_compiler_flags` Differential Revision: D72255474
drisspg
approved these changes
Apr 3, 2025
stepanhruda
added a commit
to stepanhruda/executorch
that referenced
this pull request
Apr 3, 2025
Summary: X-link: pytorch/pytorch#150487 Had to revert D71321310 because it affected way too many targets and build sizes. These changes should expose just enough symbols to be buildable in arvr mode on macOS. Could potentially make narrow it down even more by avoiding eg `get_pt_compiler_flags` Differential Revision: D72255474
stepanhruda
force-pushed
the
export-D72255474
branch
from
1714ca0 to
271560a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D72255474 |
stepanhruda
added a commit
to stepanhruda/pytorch
that referenced
this pull request
Apr 3, 2025
Summary: X-link: pytorch/executorch#9819 Had to revert D71321310 because it affected way too many targets and build sizes. These changes should expose just enough symbols to be buildable in arvr mode on macOS. Could potentially make narrow it down even more by avoiding eg `get_pt_compiler_flags` Differential Revision: D72255474
stepanhruda
added a commit
to stepanhruda/pytorch
that referenced
this pull request
Apr 4, 2025
Summary: X-link: pytorch/executorch#9819 Had to revert D71321310 because it affected way too many targets and build sizes. These changes should expose just enough symbols to be buildable in arvr mode on macOS. Could potentially make narrow it down even more by avoiding eg `get_pt_compiler_flags` Differential Revision: D72255474
stepanhruda
added a commit
to stepanhruda/pytorch
that referenced
this pull request
Apr 4, 2025
Summary: X-link: pytorch/executorch#9819 Had to revert D71321310 because it affected way too many targets and build sizes. These changes should expose just enough symbols to be buildable in arvr mode on macOS. Could potentially make narrow it down even more by avoiding eg `get_pt_compiler_flags` Differential Revision: D72255474
stepanhruda
force-pushed
the
export-D72255474
branch
from
271560a to
27b1cf4
Compare
stepanhruda
added a commit
to stepanhruda/executorch
that referenced
this pull request
Apr 4, 2025
Summary: X-link: pytorch/pytorch#150487 Had to revert D71321310 because it affected way too many targets and build sizes. These changes should expose just enough symbols to be buildable in arvr mode on macOS. Could potentially make narrow it down even more by avoiding eg `get_pt_compiler_flags` Differential Revision: D72255474
stepanhruda
added a commit
to stepanhruda/pytorch
that referenced
this pull request
Apr 4, 2025
Summary: X-link: pytorch/executorch#9819 Had to revert D71321310 because it affected way too many targets and build sizes. These changes should expose just enough symbols to be buildable in arvr mode on macOS. Could potentially make narrow it down even more by avoiding eg `get_pt_compiler_flags` Differential Revision: D72255474
Summary: X-link: pytorch/pytorch#150487 Pull Request resolved: pytorch#9819 Had to revert D71321310 because it affected way too many targets and build sizes. These changes should expose just enough symbols to be buildable in arvr mode on macOS. Could potentially make narrow it down even more by avoiding eg `get_pt_compiler_flags` Differential Revision: D72255474
|
This pull request was exported from Phabricator. Differential Revision: D72255474 |
stepanhruda
force-pushed
the
export-D72255474
branch
from
27b1cf4 to
2df119c
Compare
stepanhruda
added a commit
to stepanhruda/pytorch
that referenced
this pull request
Apr 4, 2025
Summary: Pull Request resolved: pytorch#150487 X-link: pytorch/executorch#9819 Had to revert D71321310 because it affected way too many targets and build sizes. These changes should expose just enough symbols to be buildable in arvr mode on macOS. Could potentially make narrow it down even more by avoiding eg `get_pt_compiler_flags` Differential Revision: D72255474
larryliu0820
approved these changes
Apr 4, 2025
facebook-github-bot
pushed a commit
to facebook/folly
that referenced
this pull request
Apr 4, 2025
Summary: X-link: pytorch/pytorch#150487 X-link: pytorch/executorch#9819 Had to revert D71321310 because it affected way too many targets and build sizes. These changes should expose just enough symbols to be buildable in arvr mode on macOS. Could potentially make narrow it down even more by avoiding eg `get_pt_compiler_flags` Reviewed By: drisspg Differential Revision: D72255474 fbshipit-source-id: a196d32526ef826be3baf6ab53e9e0949718bec1
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Apr 4, 2025
Summary: X-link: pytorch/executorch#9819 Had to revert D71321310 because it affected way too many targets and build sizes. These changes should expose just enough symbols to be buildable in arvr mode on macOS. Could potentially make narrow it down even more by avoiding eg `get_pt_compiler_flags` Differential Revision: D72255474 Pull Request resolved: #150487 Approved by: https://github.com/drisspg
kirklandsign
pushed a commit
that referenced
this pull request
Apr 11, 2025
Differential Revision: D72255474 Pull Request resolved: #9819
timocafe
pushed a commit
to timocafe/pytorch
that referenced
this pull request
Apr 16, 2025
Summary: X-link: pytorch/executorch#9819 Had to revert D71321310 because it affected way too many targets and build sizes. These changes should expose just enough symbols to be buildable in arvr mode on macOS. Could potentially make narrow it down even more by avoiding eg `get_pt_compiler_flags` Differential Revision: D72255474 Pull Request resolved: pytorch#150487 Approved by: https://github.com/drisspg
amathewc
pushed a commit
to amathewc/pytorch
that referenced
this pull request
Apr 17, 2025
Summary: X-link: pytorch/executorch#9819 Had to revert D71321310 because it affected way too many targets and build sizes. These changes should expose just enough symbols to be buildable in arvr mode on macOS. Could potentially make narrow it down even more by avoiding eg `get_pt_compiler_flags` Differential Revision: D72255474 Pull Request resolved: pytorch#150487 Approved by: https://github.com/drisspg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Had to revert D71321310 because it affected way too many targets and build sizes.
These changes should expose just enough symbols to be buildable in arvr mode on macOS. Could potentially make narrow it down even more by avoiding eg
get_pt_compiler_flagsDifferential Revision: D72255474