-
Notifications
You must be signed in to change notification settings - Fork 537
Try upgrading to CoreML Tools 8.2 #9807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test Plan: Wait for CI cc @cymbalrush , @YifanShenSZ (cherry picked from commit b66c319)
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9807
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 4655097 with merge base 771588a ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@guangy10 @shoumikhin can you have a look at the failing iOS demo app test? |
Maybe @huydhn knows? |
I only know the issue is from this GitHub Action: https://github.com/pytorch/test-infra/blob/934a67aa9a9e90a74678e4aa6d9cc49d055e59fd/.github/workflows/mobile_job.yml#L318, but have no idea why the git job name is missing when you updated the coremltools version. @yangw-dev @ZainRizvi Do you guys know? |
Oh, we need to cherry pick pytorch/test-infra#6391 into https://github.com/pytorch/test-infra/commits/release/2.7 as this new parameter was added recently. @yangw-dev Could you help a cherry pick for pytorch/test-infra#6391 plz? You would need to do it manually as I think cherry pick bot is not available on test-infra yet. |
sounds good! will do! |
(https://github.com/pytorch/test-infra/pull/6391[)](https://github.com/pytorch/test-infra/commit/91ec159eb773bd9e301472cddd749da62608937d) is in https://github.com/pytorch/test-infra/commits/release/2.7 now. confirmed with andrey, this is fine. |
@metascroy CI is green now after the cp into test-infra |
Test Plan: Wait for CI
cc @cymbalrush , @YifanShenSZ