Skip to content

Try upgrading to CoreML Tools 8.2 #9807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 4, 2025

Conversation

pytorchbot
Copy link
Collaborator

Test Plan: Wait for CI

cc @cymbalrush , @YifanShenSZ

Test Plan: Wait for CI

cc @cymbalrush , @YifanShenSZ

(cherry picked from commit b66c319)
Copy link

pytorch-bot bot commented Apr 1, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9807

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 4655097 with merge base 771588a (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 1, 2025
@metascroy
Copy link
Contributor

@guangy10 @shoumikhin can you have a look at the failing iOS demo app test?

@shoumikhin
Copy link
Contributor

Maybe @huydhn knows?

@guangy10
Copy link
Contributor

guangy10 commented Apr 1, 2025

@guangy10 @shoumikhin can you have a look at the failing iOS demo app test?

I only know the issue is from this GitHub Action: https://github.com/pytorch/test-infra/blob/934a67aa9a9e90a74678e4aa6d9cc49d055e59fd/.github/workflows/mobile_job.yml#L318, but have no idea why the git job name is missing when you updated the coremltools version. @yangw-dev @ZainRizvi Do you guys know?

@huydhn
Copy link
Contributor

huydhn commented Apr 2, 2025

Oh, we need to cherry pick pytorch/test-infra#6391 into https://github.com/pytorch/test-infra/commits/release/2.7 as this new parameter was added recently.

@yangw-dev Could you help a cherry pick for pytorch/test-infra#6391 plz? You would need to do it manually as I think cherry pick bot is not available on test-infra yet.

@yangw-dev
Copy link
Contributor

sounds good! will do!

@yangw-dev
Copy link
Contributor

(https://github.com/pytorch/test-infra/pull/6391[)](https://github.com/pytorch/test-infra/commit/91ec159eb773bd9e301472cddd749da62608937d) is in https://github.com/pytorch/test-infra/commits/release/2.7 now.

confirmed with andrey, this is fine.

@mergennachin
Copy link
Contributor

@metascroy CI is green now after the cp into test-infra

@metascroy metascroy merged commit f954ec7 into release/0.6 Apr 4, 2025
176 checks passed
@metascroy metascroy deleted the cherry-pick-9799-by-pytorch_bot_bot_ branch April 4, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants