Skip to content

Arm backend: Fix flaky sigmoid 16/32 bit tests #9537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2025

Conversation

Erik-Lundell
Copy link
Collaborator

@Erik-Lundell Erik-Lundell commented Mar 24, 2025

  • Change constant test data to random generators.
  • Tests on Ethos-U55 are meant to xfail as int 16 tables are currently not supported.
  • For other tests, add flaky marker. Remove increased qtol, since the inaccuracies only show up sporadically.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

- Change constant test data to random generators
- Tests on Ethos-U55 are meant to xfail as
int 16 tables are currently not supported.
- For other tests, add flaky marker. Remove increased
qtol, since the inaccuracies only show up sporadically.

Signed-off-by: Erik Lundell <erik.lundell@arm.com>
Change-Id: I2e07868f82f78150095aeedc4deecdb4c8431edd
@Erik-Lundell Erik-Lundell added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk topic: not user facing labels Mar 24, 2025
Copy link

pytorch-bot bot commented Mar 24, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9537

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures

As of commit 00d5d79 with merge base 8cd1b93 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 24, 2025
@zingo
Copy link
Collaborator

zingo commented Mar 24, 2025

Fails are unrelated

@zingo zingo merged commit 043c7a0 into pytorch:main Mar 24, 2025
161 of 165 checks passed
@Erik-Lundell Erik-Lundell deleted the fix-sigmoid branch March 24, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants