[ET-VK] Adding boolean parameters to add_copy_offset_node to specify index calculation function in copy op's shader. #9343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…index calculation function in copy op's shader. This diff adds two new boolean flags, `calc_out_pos_using_src_chnl` and `calc_in_pos_using_dst_chnl` to add_copy_offset_node, which can be used to specify an indexing function in the shader. Differential Revision: [D71343588](https://our.internmc.facebook.com/intern/diff/D71343588/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9343
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 3525f25 with merge base 1ccc5a0 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
This was referenced Mar 17, 2025
|
This pull request was exported from Phabricator. Differential Revision: D71343588 |
yipjustin
approved these changes
Mar 19, 2025
…to specify index calculation function in copy op's shader." This diff adds two new boolean flags, `calc_out_pos_using_src_chnl` and `calc_in_pos_using_dst_chnl` to add_copy_offset_node, which can be used to specify an indexing function in the shader. Differential Revision: [D71343588](https://our.internmc.facebook.com/intern/diff/D71343588/) [ghstack-poisoned]
This was referenced Mar 19, 2025
|
This pull request was exported from Phabricator. Differential Revision: D71343588 |
facebook-github-bot
merged commit 09e591d
into
gh/trivedivivek/64/base
81 of 83 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
kirklandsign
pushed a commit
that referenced
this pull request
Mar 20, 2025
…index calculation function in copy op's shader. Pull Request resolved: #9343 This diff adds two new boolean flags, `calc_out_pos_using_src_chnl` and `calc_in_pos_using_dst_chnl` to add_copy_offset_node, which can be used to specify an indexing function in the shader. ghstack-source-id: 272554190 @exported-using-ghexport Differential Revision: [D71343588](https://our.internmc.facebook.com/intern/diff/D71343588/)
trivedivivek
added a commit
that referenced
this pull request
Mar 20, 2025
…index calculation function in copy op's shader. (#9437) This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #9343 by @trivedivivek ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/trivedivivek/64/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/trivedivivek/64/head Merge bot PR base: https://github.com/pytorch/executorch/tree/main Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/trivedivivek/64/orig @diff-train-skip-merge --------- Co-authored-by: Vivek Trivedi <5340687+trivedivivek@users.noreply.github.com>
oscarandersson8218
pushed a commit
to oscarandersson8218/executorch
that referenced
this pull request
Mar 21, 2025
…index calculation function in copy op's shader. (pytorch#9437) This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: pytorch#9343 by @trivedivivek ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/trivedivivek/64/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/trivedivivek/64/head Merge bot PR base: https://github.com/pytorch/executorch/tree/main Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/trivedivivek/64/orig @diff-train-skip-merge --------- Co-authored-by: Vivek Trivedi <5340687+trivedivivek@users.noreply.github.com>
DannyYuyang-quic
pushed a commit
to CodeLinaro/executorch
that referenced
this pull request
Apr 2, 2025
…index calculation function in copy op's shader. (pytorch#9437) This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: pytorch#9343 by @trivedivivek ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/trivedivivek/64/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/trivedivivek/64/head Merge bot PR base: https://github.com/pytorch/executorch/tree/main Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/trivedivivek/64/orig @diff-train-skip-merge --------- Co-authored-by: Vivek Trivedi <5340687+trivedivivek@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This diff adds two new boolean flags,
calc_out_pos_using_src_chnlandcalc_in_pos_using_dst_chnlto add_copy_offset_node, which can be used to specify an indexing function in the shader.Differential Revision: D71343588