Skip to content

Conversation

jathu
Copy link
Contributor

@jathu jathu commented Mar 14, 2025

Summary

The default wheel gets built in dist/, so let's ignore it.

Test plan

$ python setup.py bdist_wheel

# dist/ should not show up
$ git status

cc @larryliu0820 @lucylq

Copy link

pytorch-bot bot commented Mar 14, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9282

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit 5fde937 with merge base bcc1259 (image):

NEW FAILURE - The following job has failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 14, 2025
@jathu jathu requested a review from larryliu0820 March 14, 2025 18:04
@jathu jathu added the module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch label Mar 14, 2025
@github-project-automation github-project-automation bot moved this to To triage in ExecuTorch DevX Mar 14, 2025
@jathu jathu force-pushed the jathu/ignore-dist branch from b3541a2 to 5fde937 Compare March 14, 2025 18:05
@jathu jathu marked this pull request as ready for review March 14, 2025 18:06
@jathu jathu requested review from swolchok and mergennachin March 14, 2025 18:27
@jathu jathu merged commit 0b1b77d into main Mar 14, 2025
78 of 81 checks passed
@github-project-automation github-project-automation bot moved this from To triage to Done in ExecuTorch DevX Mar 14, 2025
@jathu jathu deleted the jathu/ignore-dist branch March 14, 2025 20:04
DannyYuyang-quic pushed a commit to CodeLinaro/executorch that referenced this pull request Apr 2, 2025
### Summary
The default wheel gets built in `dist/`, so let's ignore it.

### Test plan

```bash
$ python setup.py bdist_wheel

# dist/ should not show up
$ git status
```

cc @larryliu0820 @lucylq
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch topic: not user facing
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants