Skip to content

[NOT LAND] Fix MediaTek license headers #9271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[NOT LAND] Fix MediaTek license headers #9271

wants to merge 1 commit into from

Conversation

mergennachin
Copy link
Contributor

@mergennachin mergennachin commented Mar 14, 2025 •
edited by pytorch-bot bot
Loading

There shouldn't be anything proprietery. According to Contribution License Agreement, the code contributed should be open sourced under BSD license

cc @cccclai @neuropilot-captain @cbilgin

@mergennachin mergennachin requested a review from cccclai as a code owner March 14, 2025 15:21
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Mar 14, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9271

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 2 Unrelated Failures

As of commit 39d8894 with merge base 75e7811 (image):

NEW FAILURE - The following job has failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 14, 2025
@github-actions GitHub Actions
Copy link

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

mergennachin
mergennachin commented Mar 14, 2025
View reviewed changes
examples/mediatek/executor_runner/mtk_llama_executor_runner.cpp
*
* This software/firmware and related documentation ("MediaTek Software") are
* protected under relevant copyright laws. The information contained herein
* is confidential and proprietary to MediaTek Inc. and/or its licensors.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be proprietery to MediaTek. According to CLA, the code is open sourced with BSD license.

mergennachin
mergennachin commented Mar 14, 2025
View reviewed changes
examples/mediatek/executor_runner/mtk_llama_runner.cpp
*
* This software/firmware and related documentation ("MediaTek Software") are
* protected under relevant copyright laws. The information contained herein
* is confidential and proprietary to MediaTek Inc. and/or its licensors.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be proprietery to MediaTek. According to CLA, the code is open sourced with BSD license.

@mergennachin
Copy link
Contributor Author

cc @neuropilot-captain

@mergennachin mergennachin added the partner: mediatek Issues related to the Mediatek delegate label Mar 14, 2025
@mergennachin mergennachin marked this pull request as draft March 14, 2025 16:33
@mergennachin mergennachin mentioned this pull request Mar 14, 2025
Closed
@mergennachin
Copy link
Contributor Author

mergennachin commented Mar 14, 2025 •
edited
Loading

I will not land this PR myself - this is just for reference. Please make a separate PR yourself.

Tracking issue #9279

@mergennachin mergennachin changed the title Fix MediaTek license headers [NOT LAND] Fix MediaTek license headers Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cccclai cccclai Awaiting requested review from cccclai cccclai is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: mediatek Issues related to the Mediatek delegate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mergennachin @facebook-github-bot