Arm backend: Fix output_folder not created issue in scripts #9269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YufengShi-dudu
added
partner: arm
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9269
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 Cancelled JobAs of commit 92b9bea with merge base 5a5fab7 ( CANCELLED JOB - The following job was cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
@GregoryComer, @digantdesai, @swolchok can you take a look please? |
zingo
approved these changes
Mar 17, 2025
|
@YufengShi-dudu This unfortunately needs a rebase. |
In files build_executorch_runner.sh and examples/arm/run.sh,
realpath command is called on output_folder before checking
whether the directory already exists. This will trigger the
error like "realpath: ${output_folder}: No such file or
directory."
Fix it by moving mkdir forward.
Change-Id: Ic8d673510a15f654ca4da72c4bc01dc0e5e20bbc
Signed-off-by: Yufeng Shi <yufeng.shi@arm.com>
YufengShi-dudu
force-pushed
the
fix-output_folder-issue
branch
from
9427b7e to
a2887ed
Compare
|
Hi all, I have rebased my patch and made a minor change to it. Please review it again. Thank you |
|
MacOS fails unrelated |
oscarandersson8218
pushed a commit
to oscarandersson8218/executorch
that referenced
this pull request
Mar 21, 2025
…9269) In files build_executorch_runner.sh and examples/arm/run.sh, realpath command is called on output_folder before checking whether the directory already exists. This will trigger the error like "realpath: ${output_folder}: No such file or directory." Fix it by moving mkdir forward. Signed-off-by: Yufeng Shi <yufeng.shi@arm.com>
DannyYuyang-quic
pushed a commit
to CodeLinaro/executorch
that referenced
this pull request
Apr 2, 2025
…9269) In files build_executorch_runner.sh and examples/arm/run.sh, realpath command is called on output_folder before checking whether the directory already exists. This will trigger the error like "realpath: ${output_folder}: No such file or directory." Fix it by moving mkdir forward. Signed-off-by: Yufeng Shi <yufeng.shi@arm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In files build_executorch_runner.sh and examples/arm/run.sh, realpath command is called on output_folder before checking whether the directory already exists. This will trigger the error like "realpath: ${output_folder}: No such file or directory."
Fix it by moving mkdir forward.
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218