Skip to content

Use parallel_for in elementwise_util #9243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 162 commits into from
Mar 18, 2025
Merged

Use parallel_for in elementwise_util #9243

merged 162 commits into from
Mar 18, 2025

Conversation

swolchok
Copy link
Contributor

More straightforward rollout.

(Parallelizing over BroadcastIndexesRange is ugly, but so far we have exactly two instances of it. If it keeps cropping up, we can add a utility to make it nicer.)

swolchok added 30 commits March 4, 2025 11:35
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

hmm, not good that this is breaking tests.

[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
Base automatically changed from gh/swolchok/369/head to main March 18, 2025 16:24
@swolchok
Copy link
Contributor Author

parallelizing copy.out seems to be what's breaking the tests, which is troubling since it's not at all clear why that would happen

[ghstack-poisoned]
[ghstack-poisoned]
@swolchok swolchok changed the base branch from main to gh/swolchok/378/head March 18, 2025 20:49
@swolchok swolchok marked this pull request as ready for review March 18, 2025 20:53
@swolchok swolchok added the release notes: ops & kernels Changes to the opset and any new / changed kernel implementations label Mar 18, 2025
Base automatically changed from gh/swolchok/378/head to main March 18, 2025 21:39
@swolchok swolchok merged commit a28e9be into main Mar 18, 2025
78 of 79 checks passed
@swolchok swolchok deleted the gh/swolchok/358/head branch March 18, 2025 23:52
oscarandersson8218 pushed a commit to oscarandersson8218/executorch that referenced this pull request Mar 21, 2025
More straightforward rollout.

(Parallelizing over BroadcastIndexesRange is ugly, but so far we have
exactly two instances of it. If it keeps cropping up, we can add a
utility to make it nicer.)
DannyYuyang-quic pushed a commit to CodeLinaro/executorch that referenced this pull request Apr 2, 2025
More straightforward rollout.

(Parallelizing over BroadcastIndexesRange is ugly, but so far we have
exactly two instances of it. If it keeps cropping up, we can add a
utility to make it nicer.)
@swolchok
Copy link
Contributor Author

this was for #8932

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: ops & kernels Changes to the opset and any new / changed kernel implementations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants