-
Notifications
You must be signed in to change notification settings - Fork 536
Use parallel_for in elementwise_util #9243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmm, not good that this is breaking tests. |
parallelizing copy.out seems to be what's breaking the tests, which is troubling since it's not at all clear why that would happen |
manuelcandales
approved these changes
Mar 18, 2025
oscarandersson8218
pushed a commit
to oscarandersson8218/executorch
that referenced
this pull request
Mar 21, 2025
More straightforward rollout. (Parallelizing over BroadcastIndexesRange is ugly, but so far we have exactly two instances of it. If it keeps cropping up, we can add a utility to make it nicer.)
DannyYuyang-quic
pushed a commit
to CodeLinaro/executorch
that referenced
this pull request
Apr 2, 2025
More straightforward rollout. (Parallelizing over BroadcastIndexesRange is ugly, but so far we have exactly two instances of it. If it keeps cropping up, we can add a utility to make it nicer.)
this was for #8932 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
release notes: ops & kernels
Changes to the opset and any new / changed kernel implementations
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More straightforward rollout.
(Parallelizing over BroadcastIndexesRange is ugly, but so far we have exactly two instances of it. If it keeps cropping up, we can add a utility to make it nicer.)