Skip to content

Use requirements-dev.txt to install pip deps #9167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2025

Conversation

jathu
Copy link
Contributor

@jathu jathu commented Mar 11, 2025

Summary

We don't need to duplicate the deps source.

Test plan

CI

Copy link

pytorch-bot bot commented Mar 11, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9167

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 167a8dc with merge base 498795b (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 11, 2025
@jathu jathu marked this pull request as ready for review March 11, 2025 22:04
@jathu jathu requested a review from larryliu0820 March 11, 2025 22:09
@jathu jathu added the module: ci Issues related to continuous integration label Mar 11, 2025
Base automatically changed from jathu/rename-macos-wheel-workflow to main March 12, 2025 15:41
@jathu jathu force-pushed the jathu/update-wheel-pip-install branch from 4d9d77c to 2c7aed7 Compare March 12, 2025 15:41
@jathu jathu added the release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc. label Mar 12, 2025
@jathu jathu force-pushed the jathu/update-wheel-pip-install branch from 2c7aed7 to 167a8dc Compare March 12, 2025 17:37
@jathu jathu merged commit d707e05 into main Mar 12, 2025
55 of 56 checks passed
@jathu jathu deleted the jathu/update-wheel-pip-install branch March 12, 2025 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: ci Issues related to continuous integration release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants