Add NamedData to flat_tensor schema #9123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows opaque data blobs inside PTD files. Differential Revision: [D70530888](https://our.internmc.facebook.com/intern/diff/D70530888/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9123
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit e687d71 with merge base 94ec549 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
lucylq
added a commit
that referenced
this pull request
Mar 11, 2025
This allows opaque data blobs inside PTD files. Differential Revision: [D70530888](https://our.internmc.facebook.com/intern/diff/D70530888/) ghstack-source-id: 270932272 Pull Request resolved: #9123
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D70530888 |
Merged
lucylq
added
release notes: api
|
code looks fine to me but I'm probably not the right person to review if schema changes are the right thing. let me know if there's nobody else ramped up either and I'll try to get context. |
JacobSzwejbka
approved these changes
Mar 24, 2025
This allows opaque data blobs inside PTD files. Differential Revision: [D70530888](https://our.internmc.facebook.com/intern/diff/D70530888/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D70530888 |
facebook-github-bot
merged commit 5a1822c
into
gh/lucylq/57/base
82 of 83 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
lucylq
added a commit
that referenced
this pull request
Mar 25, 2025
This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #9123 by @lucylq ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/lucylq/57/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/lucylq/57/head Merge bot PR base: https://github.com/pytorch/executorch/tree/main Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/lucylq/57/orig @diff-train-skip-merge Co-authored-by: lucylq <lfq@meta.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This allows opaque data blobs inside PTD files.
Differential Revision: D70530888