Skip to content

Cleanup XNN delegate post removal of upsample decomposition #8910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Cleanup XNN delegate post removal of upsample decomposition #8910

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
84c76fc
Cleanup XNN delegate post removal of upsample decomposition
GregoryComer Mar 4, 2025
0246ac2
Merge branch 'main' into export-D68374585
digantdesai Mar 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions backends/xnnpack/_passes/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,6 @@
)
from executorch.backends.xnnpack._passes.convert_to_linear import ConvertToLinearPass
from executorch.backends.xnnpack._passes.convert_to_sdpa import ConvertToSDPAPass
from executorch.backends.xnnpack._passes.convert_to_upsample_bilinear2d import (
ConvertToUpsampleBilinear2d,
)
from executorch.backends.xnnpack._passes.decompose_cat import DecomposeConcatenate
from executorch.backends.xnnpack._passes.fuse_activation_pass import FuseActivationPass
from executorch.backends.xnnpack._passes.fuse_batch_norm_with_conv import (
Expand Down Expand Up @@ -58,7 +55,6 @@ def __init__(
self.passes = [
# TODO - remove this pass once we have a better support for dim_order ops lowering
DimOrderOpsRevertPass,
ConvertToUpsampleBilinear2d,
ConvertToLinearPass,
ConvertToSDPAPass,
ConstPropPass,
Expand Down
65 changes: 0 additions & 65 deletions backends/xnnpack/_passes/convert_to_upsample_bilinear2d.py
View file
Open in desktop

This file was deleted.

57 changes: 0 additions & 57 deletions backends/xnnpack/partition/graphs/bilinear_2d.py
View file
Open in desktop

This file was deleted.

12 changes: 2 additions & 10 deletions backends/xnnpack/test/ops/test_bilinear2d.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,17 +133,9 @@ def test_fp32_bilinear2d_dynamic_bilinear2d_not_partitioned(self):
3: torch.export.Dim("w", min=1, max=12),
}
}
artifact_str = str(
(
Tester(self.StaticResizeBilinear2dModule(), example_inputs)
.export(Export(dynamic_shapes))
.to_edge_transform_and_lower()
.get_artifact()
.exported_program()
)
# NOTE The decomposition can be partially delegated. This will need to be replaced
# with the aten upsample op once decomp is removed.
self.assertTrue(
"executorch_exir_dialects_edge__ops_aten_index_Tensor" in artifact_str
or "executorch_exir_dialects_edge__ops_aten_upsample_bilinear2d_vec"
in artifact_str
.check("executorch_exir_dialects_edge__ops_aten_upsample_bilinear2d_vec")
)
Loading