Skip to content

Fail the benchmark job if the export step fails #8786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 28, 2025
Merged

Fail the benchmark job if the export step fails #8786

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e0b6210
Fail the benchmark job if the export step fails
huydhn Feb 27, 2025
3530731
Try to run it in the test phase
huydhn Feb 27, 2025
5cb328d
Ready for review
huydhn Feb 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/android-perf.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ on:
description: Models to be benchmarked
required: false
type: string
default: stories110M
default: llama
devices:
description: Target devices to run benchmark
required: false
Expand All @@ -36,7 +36,7 @@ on:
description: Models to be benchmarked
required: false
type: string
default: stories110M
default: llama
devices:
description: Target devices to run benchmark
required: false
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/apple-perf.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ on:
description: Models to be benchmarked
required: false
type: string
default: stories110M
default: llama
devices:
description: Target devices to run benchmark
required: false
Expand All @@ -36,7 +36,7 @@ on:
description: Models to be benchmarked
required: false
type: string
default: stories110M
default: llama
devices:
description: Target devices to run benchmark
required: false
Expand Down
4 changes: 4 additions & 0 deletions extension/benchmark/android/benchmark/android-llm-device-farm-test-spec.yml.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,10 @@ phases:

test:
commands:
# Fail the test if the model doesn't exist, doing it here so that AWS can report the status back
- echo "Verify model"
- curl -I --fail '{{ model_path }}' || false

# By default, the following ADB command is used by Device Farm to run your Instrumentation test.
# Please refer to Android's documentation for more options on running instrumentation tests with adb:
# https://developer.android.com/studio/test/command-line#run-tests-with-adb
Expand Down
5 changes: 5 additions & 0 deletions extension/benchmark/apple/Benchmark/default-ios-device-farm-appium-test-spec.yml.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,11 @@ phases:
# The test phase includes commands that run your test suite execution.
test:
commands:
# Fail the test if the model doesn't exist, doing it here so that AWS can report the status back
- echo "Verify model"
- curl -I --fail '{{ model_path }}' || false

# Run the benchmark
- xcodebuild test-without-building -destination id=$DEVICEFARM_DEVICE_UDID -xctestrun $DEVICEFARM_TEST_PACKAGE_PATH/*.xctestrun -derivedDataPath $DEVICEFARM_LOG_DIR

# The post test phase includes are commands that are run after your tests are executed.
Expand Down
Loading