-
Notifications
You must be signed in to change notification settings - Fork 713
Enable quantized cat #8757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable quantized cat #8757
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8757
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ⏳ No Failures, 2 PendingAs of commit e032497 with merge base 316099f ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D69499329 |
Summary: As titled. Use it only in the WakeWord quantizer for now, because it has implications on the numerics in general. Reviewed By: zonglinpeng Differential Revision: D69499329
2e611a6 to
97fd2d0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69499329 |
Summary: Pull Request resolved: #8757 As titled. Use it only in the WakeWord quantizer for now, because it has implications on the numerics in general. Reviewed By: zonglinpeng Differential Revision: D69499329
97fd2d0 to
4135d48
Compare
Summary: As titled. Use it only in the WakeWord quantizer for now, because it has implications on the numerics in general. Reviewed By: zonglinpeng Differential Revision: D69499329
4135d48 to
df88e3d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69499329 |
Summary: Pull Request resolved: #8757 As titled. Use it only in the WakeWord quantizer for now, because it has implications on the numerics in general. Reviewed By: zonglinpeng Differential Revision: D69499329
df88e3d to
d21577d
Compare
Summary: As titled. Use it only in the WakeWord quantizer for now, because it has implications on the numerics in general. Reviewed By: tarun292, zonglinpeng Differential Revision: D69499329
d21577d to
d9effc5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69499329 |
Summary: As titled. Use it only in the WakeWord quantizer for now, because it has implications on the numerics in general. Reviewed By: tarun292, zonglinpeng Differential Revision: D69499329
d9effc5 to
bda2336
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69499329 |
|
@dbort @mergennachin @tarun292 have you seen linter errors like this one? It doesn't seem to suggest a change, and linting on my own clone of ET (native mac) is clean. Not sure how to proceed. |
|
@mcremon-meta when you run locally, do you have the same lintrunner version as the CI? https://github.com/pytorch/executorch/blob/main/CONTRIBUTING.md#lintrunner |
yes I did those exact steps this morning, so should be the same |
Summary: As titled. Use it only in the WakeWord quantizer for now, because it has implications on the numerics in general. Reviewed By: tarun292, zonglinpeng Differential Revision: D69499329
bda2336 to
fdfb5cf
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69499329 |
Summary: As titled. Use it only in the WakeWord quantizer for now, because it has implications on the numerics in general. Reviewed By: tarun292, zonglinpeng Differential Revision: D69499329
fdfb5cf to
14d115e
Compare
|
might have been trailing spaces, let's see if new version is happy. If it's that it'd be nice if the linter message could say that, since the spaces don't show on the diff view (even when I highlight) |
Summary: Pull Request resolved: #8757 As titled. Use it only in the WakeWord quantizer for now, because it has implications on the numerics in general. Reviewed By: tarun292, zonglinpeng Differential Revision: D69499329
|
This pull request was exported from Phabricator. Differential Revision: D69499329 |
14d115e to
e032497
Compare
Summary: As titled. Use it only in the WakeWord quantizer for now, because it has implications on the numerics in general.
Reviewed By: zonglinpeng
Differential Revision: D69499329