Support multi-module exports in Inspector and ETRecord#8336
Support multi-module exports in Inspector and ETRecord#8336cptspacemanspiff wants to merge 2 commits intopytorch:mainfrom
Conversation
- Added optional module_name and method_name parameters to Inspector initialization - Updated _consume_etrecord method to handle multi-module export scenarios - Modified gen_graphs_from_etrecord to support custom graph keys (for each module/method) - Updated inspector_cli to accept module and method name arguments - Improved error handling for multi-module export use cases
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8336
Note: Links to docs will display an error until the docs builds have been completed. ❌ 5 New Failures, 2 Cancelled JobsAs of commit becb19a with merge base d99970b ( NEW FAILURES - The following jobs have failed:
CANCELLED JOBS - The following jobs were cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@JacobSzwejbka, @tarun292, @Gasoonjia can you take a look please? |
| raise RuntimeError( | ||
| f"Unsupported type of edge_dialect_program passed in {type(edge_dialect_program)}." | ||
| ) | ||
| if export_modules is None: |
There was a problem hiding this comment.
I'm not sure i fully understand why you needed to add this check here?
| "--module_name", | ||
| required=False, | ||
| default=None, | ||
| help="Module Name to inspect (used with multi-module exports)", |
There was a problem hiding this comment.
What is module name intended to be here?
|
@cptspacemanspiff any update on this? I'm seeing a couple open questions to the code still |
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
2 similar comments
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
So, this is a prototype of changes required to get performance data out of a multi-method export with ETRecords and ETDump.
I do not have a good understanding of if this is correct/the best way, and my understanding of the performance analysis stuff is limited.
What this does:
FWIW I was able to get the statistics table with node labeling with these changes.
From the sounds of this this might be used internally and there is probably a better way to handle this?
related to #8030