-
Notifications
You must be signed in to change notification settings - Fork 540
roll out s/IF_FALSE/UNLESS/ for ET_LOG macros #8318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8318
Note: Links to docs will display an error until the docs builds have been completed. ❌ 7 New FailuresAs of commit 69fa2ab with merge base 0beadcc ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Feb 7, 2025
swolchok
added a commit
that referenced
this pull request
Feb 7, 2025
Separating the big find/replace for the previous diff to ease review; this is just the result of ``` fastmod "(ET_LOG_(MSG_)?AND_RETURN_)IF_FALSE" "\${1}UNLESS" ``` with a manual revert in tensor_util.h for the two backward-compatibility defines. ghstack-source-id: 6d3b14c ghstack-comment-id: 2644056878 Pull Request resolved: #8318
swolchok
added a commit
that referenced
this pull request
Feb 10, 2025
Separating the big find/replace for the previous diff to ease review; this is just the result of ``` fastmod "(ET_LOG_(MSG_)?AND_RETURN_)IF_FALSE" "\${1}UNLESS" ``` with a manual revert in tensor_util.h for the two backward-compatibility defines. ghstack-source-id: a4a76d6 ghstack-comment-id: 2644056878 Pull Request resolved: #8318
ping @mergennachin @dbort @SS-JIA |
swolchok
added a commit
that referenced
this pull request
Feb 12, 2025
Separating the big find/replace for the previous diff to ease review; this is just the result of ``` fastmod "(ET_LOG_(MSG_)?AND_RETURN_)IF_FALSE" "\${1}UNLESS" ``` with a manual revert in tensor_util.h for the two backward-compatibility defines. ghstack-source-id: 502a52e ghstack-comment-id: 2644056878 Pull Request resolved: #8318
swolchok
added a commit
that referenced
this pull request
Feb 12, 2025
Separating the big find/replace for the previous diff to ease review; this is just the result of ``` fastmod "(ET_LOG_(MSG_)?AND_RETURN_)IF_FALSE" "\${1}UNLESS" ``` with a manual revert in tensor_util.h for the two backward-compatibility defines. ghstack-source-id: e48c9e5 ghstack-comment-id: 2644056878 Pull Request resolved: #8318
dbort
approved these changes
Feb 12, 2025
This was referenced Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separating the big find/replace for the previous diff to ease review; this is just the result of
with a manual revert in tensor_util.h for the two backward-compatibility defines.