Skip to content

roll out s/IF_FALSE/UNLESS/ for ET_LOG macros #8318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

swolchok
Copy link
Contributor

@swolchok swolchok commented Feb 7, 2025

Separating the big find/replace for the previous diff to ease review; this is just the result of

fastmod "(ET_LOG_(MSG_)?AND_RETURN_)IF_FALSE" "\${1}UNLESS"

with a manual revert in tensor_util.h for the two backward-compatibility defines.

[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

swolchok commented Feb 7, 2025

Copy link

pytorch-bot bot commented Feb 7, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8318

Note: Links to docs will display an error until the docs builds have been completed.

❌ 7 New Failures

As of commit 69fa2ab with merge base 0beadcc (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 7, 2025
swolchok added a commit that referenced this pull request Feb 7, 2025
Separating the big find/replace for the previous diff to ease review; this is just the result of

```
fastmod "(ET_LOG_(MSG_)?AND_RETURN_)IF_FALSE" "\${1}UNLESS"
```

with a manual revert in tensor_util.h for the two backward-compatibility defines.

ghstack-source-id: 6d3b14c
ghstack-comment-id: 2644056878
Pull Request resolved: #8318
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Feb 10, 2025
Separating the big find/replace for the previous diff to ease review; this is just the result of

```
fastmod "(ET_LOG_(MSG_)?AND_RETURN_)IF_FALSE" "\${1}UNLESS"
```

with a manual revert in tensor_util.h for the two backward-compatibility defines.

ghstack-source-id: a4a76d6
ghstack-comment-id: 2644056878
Pull Request resolved: #8318
@swolchok
Copy link
Contributor Author

ping @mergennachin @dbort @SS-JIA

[ghstack-poisoned]
swolchok added a commit that referenced this pull request Feb 12, 2025
Separating the big find/replace for the previous diff to ease review; this is just the result of

```
fastmod "(ET_LOG_(MSG_)?AND_RETURN_)IF_FALSE" "\${1}UNLESS"
```

with a manual revert in tensor_util.h for the two backward-compatibility defines.

ghstack-source-id: 502a52e
ghstack-comment-id: 2644056878
Pull Request resolved: #8318
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Feb 12, 2025
Separating the big find/replace for the previous diff to ease review; this is just the result of

```
fastmod "(ET_LOG_(MSG_)?AND_RETURN_)IF_FALSE" "\${1}UNLESS"
```

with a manual revert in tensor_util.h for the two backward-compatibility defines.

ghstack-source-id: e48c9e5
ghstack-comment-id: 2644056878
Pull Request resolved: #8318
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants