Skip to content

Use STDOUT fallback after FileNotFoundError in gather benchmarks #8258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

GregoryComer
Copy link
Member

@GregoryComer GregoryComer commented Feb 6, 2025

Summary

The gather_benchmarks job is currently failing on PyTorch Core when running ET CI. This change allows the gather_benchmarks job to gracefully fall back to logging to STDOUT when not running in the expected ET CI environment. This should unblock the ET pin bump in PyTorch.

This is a based on @guangy10's suggestion on pytorch/pytorch#145831 (comment).

Test plan

Validating via CI run.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 6, 2025
Copy link

pytorch-bot bot commented Feb 6, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8258

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link

pytorch-bot bot commented Feb 6, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8258

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ You can merge normally! (1 Unrelated Failure)

As of commit 8d933ca with merge base dad2ba0 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@GregoryComer GregoryComer requested a review from guangy10 February 6, 2025 09:08
@GregoryComer GregoryComer marked this pull request as ready for review February 6, 2025 09:09
@GregoryComer GregoryComer force-pushed the fix-benchmark-gather-output-in-pytorch-ci branch from e3fd29f to 8d933ca Compare February 6, 2025 09:55
Copy link
Contributor

@guangy10 guangy10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Now you will need to test this PR by pinning this to the pytorch CI.

To do it, you will need to make sure this PR is NOT created from your fork. After it, you can just pin the commit as how you updated the pinned executorch commit in pytorch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants