[executorch][runtime] Add NamedDataMap to method load #8200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add NamedDataMap as an arg to: - Method - load_method - parseTensor Use NamedDataMap to resolve external tensors in parseTensor. Test that the PTE + PTD file run well inside method_test. Differential Revision: [D67127327](https://our.internmc.facebook.com/intern/diff/D67127327/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8200
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit f9ca87f with merge base 8d96d74 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D67127327 |
This was referenced Feb 4, 2025
JacobSzwejbka
approved these changes
Feb 6, 2025
JacobSzwejbka
added
the
release notes: api
Add NamedDataMap as an arg to: - Method - load_method - parseTensor Use NamedDataMap to resolve external tensors in parseTensor. Test that the PTE + PTD file run well inside method_test. Differential Revision: [D67127327](https://our.internmc.facebook.com/intern/diff/D67127327/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D67127327 |
lucylq
added a commit
that referenced
this pull request
Feb 7, 2025
Pull Request resolved: #8200 Add NamedDataMap as an arg to: - Method - load_method - parseTensor Use NamedDataMap to resolve external tensors in parseTensor. Test that the PTE + PTD file run well inside method_test. TODO: additional test cases. also, tests for mutable case with load_data_into when that is landed, see D69148652. Note: dependency on D66580784, which fixes some failing RL tests exposed by this diff from inclusion of portable and aten headers. https://www.internalfb.com/code/fbsource/[2b74908ed03c34fbfd53fb57575eba0964fe0136][history]/arvr/projects/depthsensing/products/depthmanager/depth/stereo/MlStereoDisparityModelExecutorchBackend.h?lines=13-15 ghstack-source-id: 265301446 @exported-using-ghexport Differential Revision: [D67127327](https://our.internmc.facebook.com/intern/diff/D67127327/)
Add NamedDataMap as an arg to: - Method - load_method - parseTensor Use NamedDataMap to resolve external tensors in parseTensor. Test that the PTE + PTD file run well inside method_test. Differential Revision: [D67127327](https://our.internmc.facebook.com/intern/diff/D67127327/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D67127327 |
lucylq
added a commit
that referenced
this pull request
Feb 7, 2025
Pull Request resolved: #8200 Add NamedDataMap as an arg to: - Method - load_method - parseTensor Use NamedDataMap to resolve external tensors in parseTensor. Test that the PTE + PTD file run well inside method_test. TODO: additional test cases. also, tests for mutable case with load_data_into when that is landed, see D69148652. Note: dependency on D66580784, which fixes some failing RL tests exposed by this diff from inclusion of portable and aten headers. https://www.internalfb.com/code/fbsource/[2b74908ed03c34fbfd53fb57575eba0964fe0136][history]/arvr/projects/depthsensing/products/depthmanager/depth/stereo/MlStereoDisparityModelExecutorchBackend.h?lines=13-15 ghstack-source-id: 265308478 @exported-using-ghexport Differential Revision: [D67127327](https://our.internmc.facebook.com/intern/diff/D67127327/)
Add NamedDataMap as an arg to: - Method - load_method - parseTensor Use NamedDataMap to resolve external tensors in parseTensor. Test that the PTE + PTD file run well inside method_test. Differential Revision: [D67127327](https://our.internmc.facebook.com/intern/diff/D67127327/) [ghstack-poisoned]
lucylq
added a commit
that referenced
this pull request
Feb 10, 2025
Pull Request resolved: #8200 Add NamedDataMap as an arg to: - Method - load_method - parseTensor Use NamedDataMap to resolve external tensors in parseTensor. Test that the PTE + PTD file run well inside method_test. TODO: additional test cases. also, tests for mutable case with load_data_into when that is landed, see D69148652. Note: dependency on D66580784, which fixes some failing RL tests exposed by this diff from inclusion of portable and aten headers. https://www.internalfb.com/code/fbsource/[2b74908ed03c34fbfd53fb57575eba0964fe0136][history]/arvr/projects/depthsensing/products/depthmanager/depth/stereo/MlStereoDisparityModelExecutorchBackend.h?lines=13-15 ghstack-source-id: 265545111 @exported-using-ghexport Differential Revision: [D67127327](https://our.internmc.facebook.com/intern/diff/D67127327/)
|
This pull request was exported from Phabricator. Differential Revision: D67127327 |
Add NamedDataMap as an arg to: - Method - load_method - parseTensor Use NamedDataMap to resolve external tensors in parseTensor. Test that the PTE + PTD file run well inside method_test. Differential Revision: [D67127327](https://our.internmc.facebook.com/intern/diff/D67127327/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D67127327 |
lucylq
added a commit
that referenced
this pull request
Feb 11, 2025
Pull Request resolved: #8200 Add NamedDataMap as an arg to: - Method - load_method - parseTensor Use NamedDataMap to resolve external tensors in parseTensor. Test that the PTE + PTD file run well inside method_test. TODO: additional test cases. also, tests for mutable case with load_data_into when that is landed, see D69148652. Land after: #8349, which adds CMake support for FlatTensor. Note: dependency on D66580784, which fixes some failing RL tests exposed by this diff from inclusion of portable and aten headers. https://www.internalfb.com/code/fbsource/[2b74908ed03c34fbfd53fb57575eba0964fe0136][history]/arvr/projects/depthsensing/products/depthmanager/depth/stereo/MlStereoDisparityModelExecutorchBackend.h?lines=13-15 ghstack-source-id: 265828564 @exported-using-ghexport Differential Revision: [D67127327](https://our.internmc.facebook.com/intern/diff/D67127327/)
facebook-github-bot
merged commit 39cd4e4
into
gh/lucylq/38/base
45 of 47 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
lucylq
added a commit
that referenced
this pull request
Feb 12, 2025
Pull Request resolved: #8200 Add NamedDataMap as an arg to: - Method - load_method - parseTensor Use NamedDataMap to resolve external tensors in parseTensor. Test that the PTE + PTD file run well inside method_test. TODO: additional test cases. also, tests for mutable case with load_data_into when that is landed, see D69148652. Land after: #8349, which adds CMake support for FlatTensor. Note: dependency on D66580784, which fixes some failing RL tests exposed by this diff from inclusion of portable and aten headers. https://www.internalfb.com/code/fbsource/[2b74908ed03c34fbfd53fb57575eba0964fe0136][history]/arvr/projects/depthsensing/products/depthmanager/depth/stereo/MlStereoDisparityModelExecutorchBackend.h?lines=13-15 ghstack-source-id: 265828564 @exported-using-ghexport Differential Revision: [D67127327](https://our.internmc.facebook.com/intern/diff/D67127327/) Co-authored-by: lucylq <lfq@meta.com>
This was referenced Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Add NamedDataMap as an arg to:
Use NamedDataMap to resolve external tensors in parseTensor.
Test that the PTE + PTD file run well inside method_test.
Differential Revision: D67127327