Skip to content

create MetaETDumpGen class to abstract copy_tensor_to_debug_buffer function #8157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

create MetaETDumpGen class to abstract copy_tensor_to_debug_buffer function #8157

wants to merge 1 commit into from

Conversation

Gasoonjia
Copy link
Contributor

Summary: This diff creates a new class called MetaETDumpGen to abstract the copy_tensor_to_debug_buffer function from the ETDumpGen class, while keep the ETDumpGen class as it is, which makes user able to implement their own way dumping data into buffer, while make the API back-compatible.

Differential Revision: D69079952

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Feb 3, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8157

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 8ec891c with merge base 883ff14 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 3, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69079952

@Gasoonjia
Copy link
Contributor Author

@pytorchbot label "topic: not user facing"

Gasoonjia added a commit to Gasoonjia/executorch-1 that referenced this pull request Feb 3, 2025
@Gasoonjia @facebook-github-bot
create MetaETDumpGen class to abstract copy_tensor_to_debug_buffer fu…
41319f9 
…nction (pytorch#8157)

Summary:

This diff creates a new class called `MetaETDumpGen` to abstract the `copy_tensor_to_debug_buffer` function from the `ETDumpGen` class, while keep the `ETDumpGen` class as it is, which makes user able to implement their own way dumping data into buffer, while make the API back-compatible.

Differential Revision: D69079952
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69079952

Gasoonjia added a commit to Gasoonjia/executorch-1 that referenced this pull request Feb 3, 2025
@Gasoonjia @facebook-github-bot
create MetaETDumpGen class to abstract copy_tensor_to_debug_buffer fu…
fac36ed 
…nction (pytorch#8157)

Summary:

This diff creates a new class called `MetaETDumpGen` to abstract the `copy_tensor_to_debug_buffer` function from the `ETDumpGen` class, while keep the `ETDumpGen` class as it is, which makes user able to implement their own way dumping data into buffer, while make the API back-compatible.

Differential Revision: D69079952
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69079952

@Gasoonjia @facebook-github-bot
create ETDumpGenBase class to abstract copy_tensor_to_debug_buffer fu…
8ec891c 
…nction (pytorch#8157)

Summary:

This diff creates a new class called `MetaETDumpGen` to abstract the `copy_tensor_to_debug_buffer` function from the `ETDumpGen` class, while keep the `ETDumpGen` class as it is, which makes user able to implement their own way dumping data into buffer, while make the API back-compatible.

Reviewed By: tarun292

Differential Revision: D69079952
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69079952

This was referenced Feb 11, 2025
Open
Open
This was referenced Feb 24, 2025
Open
Open
@github-actions GitHub Actions
Copy link

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the stale PRs inactive for over 60 days label Aug 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@tarun292 tarun292 tarun292 approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported stale PRs inactive for over 60 days topic: not user facing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gasoonjia @facebook-github-bot @tarun292