Make sure size_test uses -Wuninitialized flags

[mergennachin]

Regression test for internal failure (https://www.internalfb.com/diff/D68509826)

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7940

• 📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 1 Pending

As of commit 57644d9 with merge base 5ee5f2f ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[swolchok]

-Werror is probably a bad idea; we're then accountable for every error that gets introduced in all compiler versions people might try to build with. (this also won't work on Windows or other non-GCC-lineage compilers)

[swolchok]

This will still break on Windows. I believe the recommended option is to use compiler-specific presets to configure non-essential flags like warnings; looking into it now.

[mergennachin]

This will still break on Windows. I believe the recommended option is to use compiler-specific presets to configure non-essential flags like warnings; looking into it now.

Btw, I am not changing that this is the default compilation option for all of ExecuTorch. I'm only changing the compile option for size_test and size_test_all_ops tests.

We don't run size_test for Windows, at least for today

[swolchok]

FWIW, -Werror is controlled by CMAKE_COMPILE_WARNING_AS_ERROR (requires CMake 3.24); it's supposed to be set either on the command line or in a preset, not in CMakeLists.txt