Skip to content

Make sure size_test uses -Wuninitialized flags #7940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Make sure size_test uses -Wuninitialized flags #7940

wants to merge 1 commit into from

Conversation

mergennachin
Copy link
Contributor

@mergennachin mergennachin commented Jan 24, 2025 •
edited
Loading

Regression test for internal failure (https://www.internalfb.com/diff/D68509826)

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jan 24, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7940

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 1 Pending

As of commit 57644d9 with merge base 5ee5f2f (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 24, 2025
@mergennachin mergennachin requested a review from swolchok January 24, 2025 18:23
swolchok
swolchok requested changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@swolchok swolchok left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-Werror is probably a bad idea; we're then accountable for every error that gets introduced in all compiler versions people might try to build with. (this also won't work on Windows or other non-GCC-lineage compilers)

@mergennachin mergennachin changed the title Make sure size_test uses -Wall, -Werror, -Wuninitialized flags Make sure size_test uses --Wuninitialized flags Jan 24, 2025
@swolchok swolchok changed the title Make sure size_test uses --Wuninitialized flags Make sure size_test uses -Wuninitialized flags Jan 24, 2025
@swolchok
Copy link
Contributor

This will still break on Windows. I believe the recommended option is to use compiler-specific presets to configure non-essential flags like warnings; looking into it now.

@mergennachin
Copy link
Contributor Author

mergennachin commented Jan 24, 2025 •
edited
Loading

This will still break on Windows. I believe the recommended option is to use compiler-specific presets to configure non-essential flags like warnings; looking into it now.

Btw, I am not changing that this is the default compilation option for all of ExecuTorch. I'm only changing the compile option for size_test and size_test_all_ops tests.

We don't run size_test for Windows, at least for today

@swolchok
Copy link
Contributor

swolchok commented Jan 24, 2025 •
edited
Loading

FWIW, -Werror is controlled by CMAKE_COMPILE_WARNING_AS_ERROR (requires CMake 3.24); it's supposed to be set either on the command line or in a preset, not in CMakeLists.txt

@mergennachin mergennachin deleted the test_regression branch January 27, 2025 16:26
@mergennachin mergennachin mentioned this pull request Jan 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swolchok swolchok swolchok requested changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mergennachin @swolchok @facebook-github-bot