Fix missing header <algorithm> in tensor_ptr.h
#6778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit import header <algorithm> explictly in extension/tensor/tensor_ptr.h, which uses `std::transfrom` defined in the header. Some recent compilers emits error (I checked gcc 14.1.0 / clang 18.1.6): ``` .../executorch/extension/tensor/tensor_ptr.h:114:12: error: no member named 'transform' in namespace 'std' ```
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6778
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 4240318 with merge base 4947e27 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
malfet
approved these changes
Nov 12, 2024
GregoryComer
approved these changes
Nov 12, 2024
|
@GregoryComer has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Thanks for catching this! Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit import header explictly in extension/tensor/tensor_ptr.h, which uses
std::transfromdefined in the header.Some recent compilers emits error (I checked gcc 14.1.0 / clang 18.1.6):