-
Notifications
You must be signed in to change notification settings - Fork 550
[llama-mm] Add export-friendly tile position embedding #6650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Before we make a decision on whether torchtune takes this export-friendly version of `TilePositionEmbedding`, we put it under `extension/llm` so that users can start to use it. Added unit tests to make sure the behavior is the same as the reference implementation in torchtune and export/AOTI/ET all working properly. Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
larryliu0820
added a commit
that referenced
this pull request
Nov 5, 2024
Summary: Before we make a decision on whether torchtune takes this export-friendly version of `TilePositionEmbedding`, we put it under `extension/llm` so that users can start to use it. Added unit tests to make sure the behavior is the same as the reference implementation in torchtune and export/AOTI/ET all working properly. Test Plan: Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: b8305d9 Pull Request resolved: #6650
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6650
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit b0d9e3f with merge base 3a1f8d2 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Summary: Before we make a decision on whether torchtune takes this export-friendly version of `TilePositionEmbedding`, we put it under `extension/llm` so that users can start to use it. Added unit tests to make sure the behavior is the same as the reference implementation in torchtune and export/AOTI/ET all working properly. Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
larryliu0820
added a commit
that referenced
this pull request
Nov 5, 2024
Summary: Before we make a decision on whether torchtune takes this export-friendly version of `TilePositionEmbedding`, we put it under `extension/llm` so that users can start to use it. Added unit tests to make sure the behavior is the same as the reference implementation in torchtune and export/AOTI/ET all working properly. Test Plan: Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 96e7da2 Pull Request resolved: #6650
tarun292
reviewed
Nov 5, 2024
tarun292
approved these changes
Nov 5, 2024
Summary: Before we make a decision on whether torchtune takes this export-friendly version of `TilePositionEmbedding`, we put it under `extension/llm` so that users can start to use it. Added unit tests to make sure the behavior is the same as the reference implementation in torchtune and export/AOTI/ET all working properly. Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
larryliu0820
added a commit
that referenced
this pull request
Nov 5, 2024
Summary: Before we make a decision on whether torchtune takes this export-friendly version of `TilePositionEmbedding`, we put it under `extension/llm` so that users can start to use it. Added unit tests to make sure the behavior is the same as the reference implementation in torchtune and export/AOTI/ET all working properly. Test Plan: Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: fe65ec6 Pull Request resolved: #6650
larryliu0820
added a commit
that referenced
this pull request
Nov 5, 2024
Summary: Before we make a decision on whether torchtune takes this export-friendly version of `TilePositionEmbedding`, we put it under `extension/llm` so that users can start to use it. Added unit tests to make sure the behavior is the same as the reference implementation in torchtune and export/AOTI/ET all working properly. Test Plan: Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: fe65ec6 Pull Request resolved: #6650 Co-authored-by: Mengwei Liu <larryliu@meta.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary:
Before we make a decision on whether torchtune takes this
export-friendly version of
TilePositionEmbedding
, we put it underextension/llm
so that users can start to use it.Added unit tests to make sure the behavior is the same as the reference
implementation in torchtune and export/AOTI/ET all working properly.
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags: