Skip to content

Qualcomm AI Engine Direct - Reduce redundant observers #6351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

winskuo-quic
Copy link
Collaborator

Summary

  • Current observer flow checks min/max/axis values to determine whether 2 observer is same. If same, it would only keep 1 observer. Providing these values helps observers to properly compare with other nodes observer, which helps reducing the number of observers, which further helps reducing time to quantize the model.

Before:
image


After:
image

Copy link

pytorch-bot bot commented Oct 18, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6351

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit 66c3e44 with merge base f7e26d7 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 18, 2024
@winskuo-quic
Copy link
Collaborator Author

Hi @cccclai,
As discussed previously, we want to reduce the numbers of observers to reduce AOT time.
This PR should be able to reduce some observers.
Please have a look.
Thanks

Copy link
Contributor

@cccclai cccclai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you

@facebook-github-bot
Copy link
Contributor

@cccclai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cccclai
Copy link
Contributor

cccclai commented Nov 5, 2024

Hi sorry I miss merging this PR, mind rebasing again?

@winskuo-quic winskuo-quic force-pushed the dev1/winskuo/reduce_redundant_observer branch from e6024c9 to 66c3e44 Compare November 6, 2024 00:57
@winskuo-quic
Copy link
Collaborator Author

Hi sorry I miss merging this PR, mind rebasing again?

All good!
I have just rebased.
Thanks

@facebook-github-bot
Copy link
Contributor

@cccclai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@digantdesai
Copy link
Contributor

Seems like there are still merge conflicts, might need another rebase?

@digantdesai digantdesai merged commit cb2a0e7 into pytorch:main Nov 7, 2024
38 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants