Skip to content

Clean up Outdated Args from Llama Export Script #5762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

YifanShenSZ
Copy link
Collaborator

2 coreml-specific args were introduced to llama export script

  1. Partition Mutable Buffer as Core ML State #5165 introduced --coreml-enable-state
  2. Preserve SDPA for CoreML #5258 introduced --coreml-preserve-sdpa

Since users would want to target iOS version rather than tune optimizations, #5319 introduced --coreml-ios 18. However, #5319 forgot to remove the outdated --coreml-enable-state and --coreml-preserve-sdpa

Copy link

pytorch-bot bot commented Sep 30, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5762

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 0b1e89c with merge base 905b88c (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 30, 2024
@YifanShenSZ YifanShenSZ marked this pull request as ready for review September 30, 2024 18:40
@YifanShenSZ
Copy link
Collaborator Author

YifanShenSZ commented Sep 30, 2024

No need to cherry pick this PR, since it won't affect any beta release functionality

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants