Skip to content

Use TensorMeta to check if inputs and outputs are memory planned #5565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

JacobSzwejbka
Copy link
Contributor

Summary: Swap to using method meta so we can be finer grained about this check

Reviewed By: dbort

Differential Revision: D62983475

Summary: Swap to using method meta so we can be finer grained about this check

Reviewed By: dbort

Differential Revision: D62983475
Copy link

pytorch-bot bot commented Sep 23, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5565

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 253b136 with merge base 8be3ce5 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 23, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62983475

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in df72b8c.

@dbort
Copy link
Contributor

dbort commented Oct 10, 2024

@pytorchbot cherry-pick --onto release/0.4 -c fixnewfeature

pytorchbot pushed a commit that referenced this pull request Oct 10, 2024
Summary:
Pull Request resolved: #5565

Swap to using method meta so we can be finer grained about this check

Reviewed By: dbort

Differential Revision: D62983475

fbshipit-source-id: c4599c5ecad0409cd8b2670464c4e9e8809b49ad
(cherry picked from commit df72b8c)
@pytorchbot
Copy link
Collaborator

Cherry picking #5565

The cherry pick PR is at #6114 and it is recommended to link a fixnewfeature cherry pick PR with an issue. The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

dbort pushed a commit that referenced this pull request Oct 11, 2024
Use TensorMeta to check if inputs and outputs are memory planned (#5565)

Summary:
Pull Request resolved: #5565

Swap to using method meta so we can be finer grained about this check

Reviewed By: dbort

Differential Revision: D62983475

fbshipit-source-id: c4599c5ecad0409cd8b2670464c4e9e8809b49ad
(cherry picked from commit df72b8c)

Co-authored-by: Jacob Szwejbka <jakeszwe@meta.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants